Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning instead pattern segments error #158

Merged

Conversation

KaterynaSloboda
Copy link
Contributor

@KaterynaSloboda KaterynaSloboda commented Dec 15, 2023

Building Blocks contains many functions that are used in Hypar examples and in the Hypar tour. Please ensure that that following are true before granting this PR.

  • The function has been published with staging, (but not released, until this PR is approved).
  • The function has been tested against the tour. If the function is not used in the tour, mark this as not applicable (NA).
  • Strings in hypar.json have been translated to supported languages in the messages field.
  • Any new project added to this repository has been added to BuildingBlocks.sln.

This change is Reviewable

@KaterynaSloboda KaterynaSloboda requested a review from a team as a code owner December 15, 2023 15:51
Copy link
Contributor

@jamesbradleym jamesbradleym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, 3 of 4 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @katehryhorenko)

@jamesbradleym jamesbradleym merged commit 6af83aa into hypar-io:master Jan 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants