handle nulls in ExtractPolygonsFromElements #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…null values in their solidoperations + profiles
jamesbradleym
requested review from
anthonie-kramer
and removed request for
a team
anthonie-kramer
suggested changes
Jan 9, 2024
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @jamesbradleym)
Grids/Grid/src/Grid.cs line 91 at r1 (raw file):
private static List<Polygon> ExtractPolygonsFromElements<T>(IEnumerable<T> elements, Func<T, Polygon> getDefaultPolygon) where T : GeometricElement { List<string> warnings = new List<string>();
Are we intending to add warnings somewhere?
Base automatically changed from
update-grid-to-latest-elements-and-function-versions
to
master
January 9, 2024 22:22
jamesbradleym
commented
Jan 11, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @anthonie-kramer)
Grids/Grid/src/Grid.cs line 91 at r1 (raw file):
Previously, anthonie-kramer (Anthonie Kramer) wrote…
Are we intending to add warnings somewhere?
Nope, this shouldn't have been added. Removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building Blocks contains many functions that are used in Hypar examples and in the Hypar tour. Please ensure that that following are true before granting this PR.
hypar.jsonhave been translated to supported languages in themessagesfield.Some elements came in with null values in their SolidOperations and Profiles. This PR bolsters null handling when attempting to extract polygon info from these elements.
This change is