Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve nested components #5

Closed
davelab6 opened this issue Dec 5, 2020 · 9 comments
Closed

Solve nested components #5

davelab6 opened this issue Dec 5, 2020 · 9 comments

Comments

@davelab6
Copy link
Contributor

davelab6 commented Dec 5, 2020

@minjooham said,

So now we have only one "fail" from fontbakery: "found-nested-components"

arrowtype/recursive#412

스크린샷 2020-12-05 01 45 03

Do you know any tips to fix this?

From From https://github.com/googlefonts/fontbakery/blame/8cf2698f36d8e6562444c0f8b09104bc75e709c5/Lib/fontbakery/profiles/glyf.py it looks like @simoncozens recently authored this check.

Simon, Do you know any tips to fix this?

I guess if this is resolved the tips should be added to the fontbakery check metadata :)

@aaronbell
Copy link
Collaborator

Looks like ufo2ft has a mechanism to flatten components on export (by adding a filter to the UFO). Maybe I’ll use GlyphsLib then ufo2ft rather than a direct fontMake export. Should solve it.

@simoncozens
Copy link

For now that’s the best answer. I’ll work on getting a fontmake flag to do it.

@minjooham
Copy link
Contributor

@aaronbell @simoncozens Could fontmake solve this? or do you have workaround proposal for now?

@simoncozens
Copy link

I have pull requests against fontmake and ufo2ft. If/when they are merged, it will be easy to solve. Until then, convert to UFO and add the lib key that Aaron mentions above.

@aaronbell
Copy link
Collaborator

@minjooham I will take care of it in a build script to convert to UFO and then build the font. No need to change the source format in the repro.

@minjooham
Copy link
Contributor

Great! Thanks a lot @aaronbell

@davelab6
Copy link
Contributor Author

What is the current status of this?

@aaronbell
Copy link
Collaborator

@davelab6 i will be able to resolve it in the build script. :)

@aaronbell
Copy link
Collaborator

The branch / PR that I created flattens components and resolves this issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants