Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: yarn will remove hyper-nano binary and __hyper__ directory on yarn install #537

Closed
TillaTheHun0 opened this issue Oct 18, 2022 · 1 comment · Fixed by #600
Closed
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed nano hyper {nano} work

Comments

@TillaTheHun0
Copy link
Member

Background

Right now, npx hyper-nano will download the hyper nano binary to the node_modules/hyper-nano/bin directory, and add the __hyper__ directory in the same place, for running services.

Problem

When yarn is ran, this removes the binary as well as the __hyper__ directory, effectively deleting all of the local data. This isn't a great DX for local development

Solution

I will probably need to download the binary to a cache folder outside of node_modules ie. how Cypress downloads its binary

For the __hyper__ folder, we can either also store in the global cache, or place it at the root of the project, similar to how next does it. Right now, hyper-nano just uses the cwd to place the __hyper__ directory, so we will have to add a config option for that.

Workaround

Downloading the binary directly from s3, placing it where you'd like it, and then running it directly, instead of via npx, will get around this issue, until a solution is implemented.

@TillaTheHun0 TillaTheHun0 added bug Something isn't working nano hyper {nano} work labels Oct 18, 2022
@TillaTheHun0 TillaTheHun0 changed the title bug: yarn will remove hyper-nano binary and __hyper__ folder on yarn install bug: yarn will remove hyper-nano binary and __hyper__ directory on yarn install Oct 18, 2022
@TillaTheHun0
Copy link
Member Author

As part of downloading the binary i'll need to also verify the integrity as highlighted in #534. I have a close to working solution for that, just have to tidy it up.

@TillaTheHun0 TillaTheHun0 self-assigned this Nov 4, 2022
@TillaTheHun0 TillaTheHun0 moved this to 🆕 New in Public Board Mar 2, 2023
@TillaTheHun0 TillaTheHun0 moved this from 🆕 New to 📋 Backlog in Public Board Mar 2, 2023
@TillaTheHun0 TillaTheHun0 added the help wanted Extra attention is needed label Mar 2, 2023
@TillaTheHun0 TillaTheHun0 moved this from 📋 Backlog to 🏗 In progress in Public Board May 24, 2023
TillaTheHun0 added a commit that referenced this issue May 30, 2023
…nd __hyper__ directory #537"

BREAKING CHANGE: the __hyper__ directory and the hyper-nano binary will now be placed in
the current working directory. Both should be added to a .gitignore so that they are not committed
to source control
TillaTheHun0 added a commit that referenced this issue May 30, 2023
TillaTheHun0 added a commit that referenced this issue May 30, 2023
…nd __hyper__ directory #537"

BREAKING CHANGE: the __hyper__ directory and the hyper-nano binary will now be placed in
the current working directory. Both should be added to a .gitignore so that they are not committed
to source control
TillaTheHun0 added a commit that referenced this issue May 30, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Public Board May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed nano hyper {nano} work
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant