Skip to content

Commit

Permalink
fix(warpConfig): Fix LUMIA/bsc-ethereum-lumia warp config (#4928)
Browse files Browse the repository at this point in the history
### Description
- Fix LUMIA/bsc-ethereum-lumia warp config, proxyAdmin address was
incorrectly set to the AW proxyAdmin in Lumia
- Recent bug fix in checker has surfaced this issue

### Drive-by changes

- Fix bug with ownership check when proxyAdmin is not set in config

### Testing

Manual
  • Loading branch information
Mo-Hussain authored Dec 4, 2024
1 parent 2054f4f commit ded8a61
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export const getEthereumBscLUMIAWarpConfig = async (
mailbox: '0x3a867fCfFeC2B790970eeBDC9023E75B0a172aa7',
proxyAdmin: {
owner: owner,
address: '0xeA87ae93Fa0019a82A727bfd3eBd1cFCa8f64f1D',
address: '0xBC53dACd8c0ac0d2bAC461479EAaf5519eCC8853',
},
};

Expand Down
2 changes: 1 addition & 1 deletion typescript/sdk/src/deploy/HyperlaneAppChecker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ export abstract class HyperlaneAppChecker<
const actualProxyAdminOwner =
await actualProxyAdminContract.owner();
const expectedOwner = this.getOwner(
actualProxyAdminOwner,
owner,
'proxyAdmin',
ownableOverrides,
);
Expand Down

0 comments on commit ded8a61

Please sign in to comment.