From ded8a6114c937c1277d3a7638e929cb88fe79040 Mon Sep 17 00:00:00 2001 From: Mohammed Hussan Date: Wed, 4 Dec 2024 11:27:58 +0000 Subject: [PATCH] fix(warpConfig): Fix LUMIA/bsc-ethereum-lumia warp config (#4928) ### Description - Fix LUMIA/bsc-ethereum-lumia warp config, proxyAdmin address was incorrectly set to the AW proxyAdmin in Lumia - Recent bug fix in checker has surfaced this issue ### Drive-by changes - Fix bug with ownership check when proxyAdmin is not set in config ### Testing Manual --- .../warp/configGetters/getEthereumBscLumiaLUMIAWarpConfig.ts | 2 +- typescript/sdk/src/deploy/HyperlaneAppChecker.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/typescript/infra/config/environments/mainnet3/warp/configGetters/getEthereumBscLumiaLUMIAWarpConfig.ts b/typescript/infra/config/environments/mainnet3/warp/configGetters/getEthereumBscLumiaLUMIAWarpConfig.ts index 1afa97f4f9..20bc3aff24 100644 --- a/typescript/infra/config/environments/mainnet3/warp/configGetters/getEthereumBscLumiaLUMIAWarpConfig.ts +++ b/typescript/infra/config/environments/mainnet3/warp/configGetters/getEthereumBscLumiaLUMIAWarpConfig.ts @@ -38,7 +38,7 @@ export const getEthereumBscLUMIAWarpConfig = async ( mailbox: '0x3a867fCfFeC2B790970eeBDC9023E75B0a172aa7', proxyAdmin: { owner: owner, - address: '0xeA87ae93Fa0019a82A727bfd3eBd1cFCa8f64f1D', + address: '0xBC53dACd8c0ac0d2bAC461479EAaf5519eCC8853', }, }; diff --git a/typescript/sdk/src/deploy/HyperlaneAppChecker.ts b/typescript/sdk/src/deploy/HyperlaneAppChecker.ts index e1f5e06b24..2b6eda45b8 100644 --- a/typescript/sdk/src/deploy/HyperlaneAppChecker.ts +++ b/typescript/sdk/src/deploy/HyperlaneAppChecker.ts @@ -137,7 +137,7 @@ export abstract class HyperlaneAppChecker< const actualProxyAdminOwner = await actualProxyAdminContract.owner(); const expectedOwner = this.getOwner( - actualProxyAdminOwner, + owner, 'proxyAdmin', ownableOverrides, );