Enhance Error Handling in setGCPSecret Function

[eyeudewj]

I’ve been looking at the setGCPSecret function, and I think we could make it more robust by enhancing its error handling and logging.

Proposed Changes

Add Try-Catch Blocks:

Wrap the main logic of the function in a try-catch block to catch any errors that occur during the execution of asynchronous operations.

Enhance Logging:

Implement more detailed logging within the catch block to capture and record error details. This will make debugging much easier.

Example Update

export async function setGCPSecret(
  secretName: string,
  secret: string,
  labels: Record<string, string>,
) {
  const fileName = `/tmp/${secretName}.txt`;
  try {
    await writeFile(fileName, secret);

    const exists = await gcpSecretExists(secretName);
    if (!exists) {
      const labelString = Object.keys(labels)
        .map((key) => `${key}=${labels[key]}`)
        .join(',');
      await execCmd(
        `gcloud secrets create ${secretName} --data-file=${fileName} --replication-policy=automatic --labels=${labelString}`,
      );
      debugLog(`Created new GCP secret for ${secretName}`);
    } else {
      await execCmd(
        `gcloud secrets versions add ${secretName} --data-file=${fileName}`,
      );
      debugLog(`Added new version to existing GCP secret for ${secretName}`);
    }
  } catch (error) {
    console.error(`Error setting GCP secret '${secretName}':`, error);
    throw error; // Re-throw after logging
  } finally {
    try {
      await rm(fileName);
    } catch (cleanupError) {
      console.warn(`Issue when trying to remove temporary file '${fileName}':`, cleanupError);
    }
  }
}