feat: implement multi-message relay #4812
Open
+74
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2ea23c1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4812 +/- ##
=======================================
Coverage 77.53% 77.53%
=======================================
Files 103 103
Lines 2110 2110
Branches 190 190
=======================================
Hits 1636 1636
Misses 453 453
Partials 21 21
|
…atch transaction.
Signed-off-by: pbio <[email protected]>
paulbalaji
reviewed
Dec 12, 2024
|
would be cool to use this for #4722 |
paulbalaji
changed the title
xeno097
reviewed
Dec 13, 2024
| @@ -19,12 +19,11 @@ export const statusCommand: CommandModuleWithWriteContext< | |||
| description: 'Dispatch transaction hash', | |||
| }, | |||
| }, | |||
| handler: async ({ context, origin, destination, id, relay, dispatchTx }) => { | |||
There was a problem hiding this comment.
Considering that the destination var is unused maybe we should remove it from the command options too so that users won't try to set it and then see unexpected results because the value is not used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
relayAllmethod to HyperlaneRelayer in SDK.Drive-by changes
getContractsin HyperlaneCoreRelated issues
Backward compatibility
Testing
Manual with ICA governance tx