Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add FeeHook and Swell to pzEth #4974

Merged
merged 23 commits into from
Dec 12, 2024
Merged

feat: Add FeeHook and Swell to pzEth #4974

merged 23 commits into from
Dec 12, 2024

Conversation

ltyu
Copy link
Contributor

@ltyu ltyu commented Dec 9, 2024

Description

Drive-by changes

Related issues

Backward compatibility

Testing

Copy link

changeset-bot bot commented Dec 9, 2024

🦋 Changeset detected

Latest commit: 9f305d0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@hyperlane-xyz/helloworld Minor
@hyperlane-xyz/widgets Minor
@hyperlane-xyz/infra Minor
@hyperlane-xyz/cli Minor
@hyperlane-xyz/sdk Minor
@hyperlane-xyz/ccip-server Minor
@hyperlane-xyz/github-proxy Minor
@hyperlane-xyz/utils Minor
@hyperlane-xyz/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ltyu ltyu marked this pull request as ready for review December 9, 2024 21:21
Copy link
Collaborator

@tkporter tkporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we add swell, can you update the warp route monitor as well?

You'll need to:

  1. update the monorepo image in https://github.com/hyperlane-xyz/hyperlane-monorepo/blob/main/typescript/infra/src/warp/helm.ts#L25 to an image that includes this new warp route
  2. do the deploy
# find existing monitor name, which depends on the warp ID
$ helm ls -n mainnet3
hyperlane-warp-route-pzeth-ethereum-zircuit

# now delete the old one
$ helm del hyperlane-warp-route-pzeth-ethereum-zircuit -n mainnet3

# and now deploy the new one
# it'll prompt interactively for you to pick the right warp ID
$ yarn tsx ./scripts/warp-routes/deploy-warp-monitor.ts -e mainnet3

@ltyu ltyu changed the base branch from ltyu/ezEth-swell-feeHook to main December 11, 2024 17:50
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (17ecb97) to head (9f305d0).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4974   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

@ltyu ltyu force-pushed the ltyu/pzEth-swell-feeHook branch from 92578fb to c390f4d Compare December 11, 2024 21:19
@ltyu ltyu added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit fd20bb1 Dec 12, 2024
43 of 45 checks passed
@ltyu ltyu deleted the ltyu/pzEth-swell-feeHook branch December 12, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants