[chore] Enhance Kagami UI regarding the validator building failures #3601
Assignees
Labels
Enhancement
New feature or request
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
QA-confirmed
This bug is reproduced and needs a fix
Comments
0x009922
added
Enhancement
|
I would prefer to implement it after |
3 tasks
3 tasks
0x009922
added a commit
that referenced
this issue
Sep 4, 2023
* [refactor]: remove Swarm from Kagami; introduce refactored `iroha_swarm` Signed-off-by: Dmitry Balashov <[email protected]> * [refactor]: remove validator from Kagami; cleanup Signed-off-by: Dmitry Balashov <[email protected]> * [misc]: fix workspace info, introduce `wasm_builder_cli` Signed-off-by: Dmitry Balashov <[email protected]> * [ci]: update Genesis and Swarm cmds in scripts Signed-off-by: Dmitry Balashov <[email protected]> * [feat]: produce workable `iroha_wasm_builder_cli` Signed-off-by: Dmitry Balashov <[email protected]> * [feat]: enhance CLI UI with spinners Signed-off-by: Dmitry Balashov <[email protected]> * [build]: remove `iroha_wasm_builder` dep from Kagami Signed-off-by: Dmitry Balashov <[email protected]> * [build]: tree-shake unused spinners Signed-off-by: Dmitry Balashov <[email protected]> * [test]: fix swarm tests Signed-off-by: Dmitry Balashov <[email protected]> * [docs]: add README for `iroha_swarm` Signed-off-by: Dmitry Balashov <[email protected]> * [refactor]: remove `UserInterface` struct Signed-off-by: Dmitry Balashov <[email protected]> * [feat]: add `--outfile` arg for wasm cli Signed-off-by: Dmitry Balashov <[email protected]> * [docs]: document how to build the default validator Signed-off-by: Dmitry Balashov <[email protected]> * [chore]: unused imports Signed-off-by: Dmitry Balashov <[email protected]> * [docs]: link the directory to the cli Signed-off-by: Dmitry Balashov <[email protected]> * [docs]: enhance warning about an inlined validator Signed-off-by: Dmitry Balashov <[email protected]> * [chore]: use stdout Signed-off-by: Dmitry Balashov <[email protected]> * [refactor]: move `wasm_builder_cli` to `./tools/` Signed-off-by: Dmitry Balashov <[email protected]> --------- Signed-off-by: Dmitry Balashov <[email protected]>
mversic
pushed a commit
that referenced
this issue
Oct 17, 2023
* [refactor]: remove Swarm from Kagami; introduce refactored `iroha_swarm` Signed-off-by: Dmitry Balashov <[email protected]> * [refactor]: remove validator from Kagami; cleanup Signed-off-by: Dmitry Balashov <[email protected]> * [misc]: fix workspace info, introduce `wasm_builder_cli` Signed-off-by: Dmitry Balashov <[email protected]> * [ci]: update Genesis and Swarm cmds in scripts Signed-off-by: Dmitry Balashov <[email protected]> * [feat]: produce workable `iroha_wasm_builder_cli` Signed-off-by: Dmitry Balashov <[email protected]> * [feat]: enhance CLI UI with spinners Signed-off-by: Dmitry Balashov <[email protected]> * [build]: remove `iroha_wasm_builder` dep from Kagami Signed-off-by: Dmitry Balashov <[email protected]> * [build]: tree-shake unused spinners Signed-off-by: Dmitry Balashov <[email protected]> * [test]: fix swarm tests Signed-off-by: Dmitry Balashov <[email protected]> * [docs]: add README for `iroha_swarm` Signed-off-by: Dmitry Balashov <[email protected]> * [refactor]: remove `UserInterface` struct Signed-off-by: Dmitry Balashov <[email protected]> * [feat]: add `--outfile` arg for wasm cli Signed-off-by: Dmitry Balashov <[email protected]> * [docs]: document how to build the default validator Signed-off-by: Dmitry Balashov <[email protected]> * [chore]: unused imports Signed-off-by: Dmitry Balashov <[email protected]> * [docs]: link the directory to the cli Signed-off-by: Dmitry Balashov <[email protected]> * [docs]: enhance warning about an inlined validator Signed-off-by: Dmitry Balashov <[email protected]> * [chore]: use stdout Signed-off-by: Dmitry Balashov <[email protected]> * [refactor]: move `wasm_builder_cli` to `./tools/` Signed-off-by: Dmitry Balashov <[email protected]> --------- Signed-off-by: Dmitry Balashov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature request
First of all, it turned out that #3473 is not very accurate ATM. It says that validator building fails when Kagami is run outside of the repo dir, but it turns out that the issue is even more specific: validator building works only when Kagami is run through Cargo!
So, the description in Kagami help messages might be improved.
Also, we can actually handle the result of validator building and attach a suggestion to the error (like it is done with
--forceprompt error). The suggestion might mention the issue again.Moreover, currently
kagami::swarm::ui's spinners mightimpl Dropand stop their "spinning" gracefully. It might improve UI a little bit too.Motivation
No response
Who can help?
@0x009922
The text was updated successfully, but these errors were encountered: