Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible for iroha_crypto to target wasm for JS SDK #4046

Closed
DCNick3 opened this issue Nov 9, 2023 · 2 comments
Closed

Make it possible for iroha_crypto to target wasm for JS SDK #4046

DCNick3 opened this issue Nov 9, 2023 · 2 comments
Labels
crypto Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@DCNick3
Copy link
Contributor

DCNick3 commented Nov 9, 2023

Currently JS SDK has to reimplement parts of iroha_crypto: https://github.com/hyperledger/iroha-javascript/tree/iroha2/packages/crypto/crypto-rs. It would be nice to remove the duplication and have the same codebase used for crypto operations between the node and js sdk.

After the PR for #3422 lands, it does make sense to try and make sure it compiles under wasm for js, so that JS SDK can use this code directly, without having to duplicate it.
@DCNick3 DCNick3 added Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST labels Nov 9, 2023
@DCNick3 DCNick3 changed the title Make it possible for iroha_crypto to target wasm for js sdk Make it possible for iroha_crypto to target wasm for JS SDK Nov 9, 2023
@DCNick3 DCNick3 mentioned this issue Nov 9, 2023
Merged
1 task
@DCNick3 DCNick3 added the crypto label Jan 10, 2024
@Arjentix
Copy link
Contributor

In #4181 wasm support was implemented. @0x009922 can you check if it works for JS SDK now?

@0x009922 0x009922 mentioned this issue Feb 20, 2024
Closed
@0x009922
Copy link
Contributor

I have created hyperledger-iroha/iroha-javascript#186 to track it.

@DCNick3 DCNick3 closed this as completed May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
crypto Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DCNick3 @Arjentix @0x009922