Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to update peer's blockstore when the whole topology changed #4145

Open
mversic opened this issue Dec 13, 2023 · 4 comments
Open

How to update peer's blockstore when the whole topology changed #4145

mversic opened this issue Dec 13, 2023 · 4 comments
Assignees
Labels
Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST question Further information is requested

Comments

@mversic
Copy link
Contributor

mversic commented Dec 13, 2023

I wounder how we should deal with more general case when whole topology changed.

Step by step:

  1. Network is started with peer set A
  2. After some height peer set A is replaced with peer set B (A intersection B = empty set)
  3. New peer is added with trusted peers peers from set B
  4. Peer get block and update it's topology to set A (because at this height only peers from topology A were present)

Originally posted by @Erigara in #4142 (comment)

@mversic mversic added iroha2-dev The re-implementation of a BFT hyperledger in RUST Bug Something isn't working question Further information is requested labels Dec 13, 2023
@SamHSmith SamHSmith self-assigned this Sep 2, 2024
@nxsaken nxsaken added this to Iroha Sep 4, 2024
@nxsaken nxsaken moved this to Backlog in Iroha Sep 4, 2024
@nxsaken nxsaken moved this from Backlog to Work in Progress in Iroha Sep 4, 2024
@nxsaken nxsaken moved this from Work in Progress to Backlog in Iroha Sep 4, 2024
@mversic
Copy link
Contributor Author

mversic commented Oct 16, 2024

@dima74 will #5117 take care of this?

@dima74
Copy link
Contributor

dima74 commented Oct 16, 2024

@dima74 will #5117 take care of this?

If all peer public keys are also changed, then no. Since we establish connection only with peers which public keys our peer know

@mversic
Copy link
Contributor Author

mversic commented Oct 16, 2024

@dima74 will #5117 take care of this?

If all peer public keys are also changed, then no. Since we establish connection only with peers which public keys our peer know

public key of a peer cannot change. That requires re-registering a peer

@dima74
Copy link
Contributor

dima74 commented Oct 16, 2024

From the issue description:

After some height peer set A is replaced with peer set B (A intersection B = empty set)

I mean if there is no such peer in set B so that its public key equals public key of some peer in set A. In such case #5117 will not help

@mversic mversic moved this from Required for MVP to Backlog in Iroha Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants