Improve handling of custom errors in receipts - capture returnValue #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Value Signed-off-by: Peter Broadhurst <[email protected]>
peterbroadhurst
commented
Feb 19, 2024
| @@ -174,7 +174,7 @@ const sampleTransactionTraceBesu = `{ | |||
| "0000000000000000000000000000000000000000000000000000000000000000" | |||
| ], | |||
| "storage": {}, | |||
| "reason": "0x8c379a0000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000000114e6f7420656e6f75676820746f6b656e73000000000000000000000000000000" | |||
There was a problem hiding this comment.
This was not a correct error - there is a missing 0 in the default Error(string) function selector 0x08c379a0
There was a problem hiding this comment.
@peterbroadhurst some nodes return the error in that format (i.e. with an odd-number of hex digits) and assume that you will pad with a single 0 client-side if it's odd. The new value you've used is valid, but the reason for including this particular reason was to emulate nodes which do that.
This was referenced Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See hyperledger/firefly#1466 for details
This PR is the first step of capturing the returnValue in cases it cannot be parsed as a default error