Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: changes to support upgrade to Fabric v2.5 TLS in Firefly CLI #1415

Closed
wants to merge 3 commits into from

Conversation

torrespro
Copy link
Contributor

Updated GO to version 1.20 (Fabric 2.5 compatibility) and Ubuntu as the base instead of Alpine.

Fixes this Issue: #1414

Related to the Firefly CLI change here: #hyperledger/firefly-cli#268

E2E test passed:

--- PASS: TestFabricMultipartyE2ESuite (137.02s)
--- PASS: TestFabricMultipartyE2ESuite/TestE2EBroadcast (3.97s)
--- PASS: TestFabricMultipartyE2ESuite/TestE2EBroadcastBlob (34.51s)
--- PASS: TestFabricMultipartyE2ESuite/TestE2EPrivate (3.74s)
--- PASS: TestFabricMultipartyE2ESuite/TestE2EPrivateBlobDatatypeTagged (3.71s)
--- PASS: TestFabricMultipartyE2ESuite/TestE2EWebhookExchange (7.61s)
--- PASS: TestFabricMultipartyE2ESuite/TestE2EWebhookRequestReplyNoTx (4.78s)
--- PASS: TestFabricMultipartyE2ESuite/TestStrongDatatypesBroadcast (7.58s)
--- PASS: TestFabricMultipartyE2ESuite/TestStrongDatatypesPrivate (7.29s)
--- PASS: TestFabricMultipartyE2ESuite/TestCustomChildIdentityBroadcasts (7.88s)
--- PASS: TestFabricMultipartyE2ESuite/TestCustomChildIdentityPrivate (11.26s)
--- PASS: TestFabricMultipartyE2ESuite/TestInvalidIdentityAlreadyRegistered (9.39s)
--- PASS: TestFabricMultipartyE2ESuite/TestE2EContractEvents (2.69s)
PASS
ok github.com/hyperledger/firefly/test/e2e/runners 137.028s

… (Fabric 2.5 compatibility) and Ubuntu as the base instead of Alpine, like Fabric does also

Signed-off-by: Andres Torres <[email protected]>
@torrespro torrespro requested a review from a team as a code owner October 4, 2023 11:52
@torrespro torrespro changed the title feature: added support to Fabric v2.5 TLS in Firefly CLI feature: changes to support upgrade to Fabric v2.5 TLS in Firefly CLI Oct 4, 2023
Dockerfile Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2023

Codecov Report

Merging #1415 (505dc2d) into main (13bf4e1) will not change coverage.
Report is 18 commits behind head on main.
The diff coverage is n/a.

❗ Current head 505dc2d differs from pull request most recent head d765789. Consider uploading reports for the commit d765789 to get more accurate results

@@           Coverage Diff           @@
##             main    #1415   +/-   ##
=======================================
  Coverage   99.99%   99.99%           
=======================================
  Files         321      321           
  Lines       23027    23027           
=======================================
  Hits        23025    23025           
  Misses          1        1           
  Partials        1        1           

@nguyer
Copy link
Contributor

nguyer commented Feb 15, 2024

Closing this PR due to inactivity. Please feel free to re-open if this work is still ongoing.
I believe the changes in the PR are actually included in this one as well: #1454

@nguyer nguyer closed this Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants