Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gdptools conus404 examples #557

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Gdptools conus404 examples #557

wants to merge 3 commits into from

Conversation

rmcd-mscb
Copy link
Member

@rmcd-mscb rmcd-mscb commented Oct 25, 2024

Pull Request Code Review

Overview

Provide notebooks illustrating gdptools processing of conus404 datasets. This PR add 3 new tutorials to the dataset_access/ folder.

  1. conus404_spatial_aggregation_DRB.ipynb: Simple Deleware River Basin example, suitable for running on a local PC
  2. conus404_spatial_aggregation_GFv1_1.ipynb: Larger Example illustrating parallel process on Hovenweep of GFv1.1 fabric
  3. conus404_spatial_aggregation_WBD12.ipynb: Larger Example illustrating parallel process on Hovenweep of CONUS HUC12s.

Links

Summary of Changes

  • See overview above

How to Run

I believe these should run with the HyTest environment. 1 - is suitable for running on a PC, 2 and 3, were run using the Hovenweep Jupyter App with 4 cores.

Peer Reviewer Expectations

1. Code Quality and Functionality

  • All code cells execute without errors.
  • Outputs match expected results.

2. Code Style and Readability

  • Variables, functions, and classes have descriptive names.
  • Sufficient comments and docstrings are present.
  • Logical organization and flow of code.

3. Documentation and Presentation

  • Clear introduction and objectives.
  • Methodology is well-explained.
  • Effective use of markdown for readability.

Not expected in Review

  • None that I can think of - looking for a complete review.

Next steps

  • List from peer reviewer of what needs to be done before branch can be merged

After author has addressed next steps peer reviewer must approve request and then branch can be merge.

@rmcd-mscb rmcd-mscb self-assigned this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create CONUS404 spatial aggregation notebook using gdptools
1 participant