Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submit ElevationEffect upstream #5

Open
iBelieve opened this issue Apr 30, 2016 · 2 comments
Open

Submit ElevationEffect upstream #5

iBelieve opened this issue Apr 30, 2016 · 2 comments
Assignees
@iBelieve
Labels
upstream review
Milestone
Version 0.1

Comments

@iBelieve
Copy link
Owner

This should be used as a layer.effect throughout the Material theme for QtQuick.Controls 2 to implement the proper elevations following the spec.
@iBelieve iBelieve self-assigned this Apr 30, 2016
@iBelieve
Copy link
Owner Author

Upstream bug report: QTBUG-51276
Upstream change request: https://codereview.qt-project.org/#/c/157640/

@iBelieve iBelieve modified the milestone: Version 0.1 May 3, 2016
@iBelieve
Copy link
Owner Author

iBelieve commented May 4, 2016

The change set has been reviewed, improved, and merged into Qt 5.7. Woot! http://code.qt.io/cgit/qt/qtquickcontrols2.git/commit/?h=5.7&id=251afe3eaac3367c5c659dddc1e8854f833d5112

Now we need to either remove the component from QuickPaper (and publically expose the private ElevationEffect from Controls 2), or update the QuickPaper version with the Controls 2 improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iBelieve iBelieve

Labels
upstream review
Projects
None yet
Milestone
Version 0.1
Development

No branches or pull requests
1 participant
@iBelieve