New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conversions.py needs test coverage for datum transformations #145

Open

danstoner opened this issue Mar 30, 2021 · 0 comments

Assignees

Labels

python3

Contributor

danstoner commented Mar 30, 2021 •

edited

Loading

We recently changed code to eliminate this warning:

tests/idb/test_helpers_conversions.py::TestGeoGrabber::test_geo_grabber
  /home/dan/git/IDIGBIO/idb-backend/idb/helpers/conversions.py:479: DeprecationWarning: This function is deprecated. See: https://pyproj4.github.io/pyproj/stable/gotchas.html#upgrading-to-pyproj-2-from-pyproj-1
    p1, p2, r["geopoint"][0], r["geopoint"][1])

but it does not appear that tests/idb/test_helpers_conversions.py specifically tests the conversion between datums.

Not clear at this time whether the code is run or not for that test..

The text was updated successfully, but these errors were encountered:

danstoner added the python3 label

danstoner self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment