-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to iTwin 4.7.2 (and newer appui) #73
Conversation
For some unknown reason, this caused our three remaining class-based React components to fail to compile, so those were converted to functional components.
@toddsouthenbentley Please carefully review the class to functional React component conversions. I think I tested them, but I'm somewhat uncomfortable about things like the fact that the |
It looks like appui-react now has a usePointerCaptor hook that works for both mouse and touch events. I would suggest using that and getting rid of the Touch* classes/functions. If you're still leery of the new code then I'd suggest staying with the old code and figuring out why it no longer builds. |
It's not at all obvious how I would update the code to use that, and it looks like that would be an even bigger rewrite than converting a class to a function.
I am investigating that, but the reality is that changing the class components to function components is a good thing. Given that everything works (resizing the resizable bottom panels), I think my conversion is correct. |
Updating |
@toddsouthenbentley As you noticed, I reverted the components I was leery about to their original class versions after fixing the problem causing the compilation errors. I left |
For some unknown reason, this caused our three remaining class-based React components to fail to compile, so those were converted to functional components.