Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial saved views widget implementation #6

Merged
merged 12 commits into from
Nov 29, 2023
Merged

Conversation

roluk
Copy link
Member

@roluk roluk commented Nov 27, 2023

Portions of this code are in various state of completion.

  • @itwin/saved-views-client is closest to being done.
  • <SavedViewTile /> consumer API is pretty much finalised, however, interactions with hover menus are clunky. I expect to improve this after upgrading to iTwinUI 4.
  • I came up with the solution for how to do string localization but it is only used with <SavedViewTile /> so far.
  • Build process for the @itwin/saved-views-react package incorporates a step which modifies CSS class names that start with svr- to begin with itwin-svr0__ to prevent accidental name collisions.
  • The test app has been partitioned into /itwinjs and /components routes. Any stored links to the test app are now broken.
  • The test app allows to browse Saved Views of published iModels but opening the view is not implemented. The app allows to make read and write Saved View requests to iTwin Platform but the result is only visible after manually refreshing the page. Expect bugs because this is the least developed part of the PR.

@roluk roluk requested a review from diegopinate November 27, 2023 15:42
@roluk roluk merged commit 552b0e8 into master Nov 29, 2023
3 checks passed
@roluk roluk deleted the saved-views-widget branch November 29, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants