New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

measure-tools-react review and fix internal api usage #1030

Open

simnorm opened this issue Aug 30, 2024 · 0 comments

simnorm commented Aug 30, 2024 •

edited

Loading

Internal API usage should be removed, work with platform for a suitable replacement

�[33m▲ �[43;33m[�[43;30mWARNING�[43;33m]�[0m �[1mclass "TelemetryEvent" is internal.�[0m �[1m�[35m[plugin build-studio-app]�[0m

local_path\node_modules\.pnpm\@[email protected]_yeitzudt4omxrstxiyiyjhhfna\node_modules\@itwin\measure-tools-react\lib\esm\api\FeatureTracking.js:59:24:

�[37m 59 │ ...nst evt = �[32mnew TelemetryEvent(feature.name, feature.guid, contex�[37m...
╵ �[32m~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~�[0m

�[33m▲ �[43;33m[�[43;30mWARNING�[43;33m]�[0m �[1mclass "TelemetryManager" is internal.�[0m �[1m�[35m[plugin build-studio-app]�[0m

local_path\node_modules\.pnpm\@[email protected]_yeitzudt4omxrstxiyiyjhhfna\node_modules\@itwin\measure-tools-react\lib\esm\api\FeatureTracking.js:60:18:

�[37m 60 │ await �[32mIModelApp.telemetry.postTelemetry(activity, evt)�[37m;
╵ �[32m~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~�[0m

�[33m▲ �[43;33m[�[43;30mWARNING�[43;33m]�[0m �[1mproperty "IModelApp.telemetry" is internal.�[0m �[1m�[35m[plugin build-studio-app]�[0m

local_path\node_modules\.pnpm\@[email protected]_yeitzudt4omxrstxiyiyjhhfna\node_modules\@itwin\measure-tools-react\lib\esm\api\FeatureTracking.js:60:18:

�[37m 60 │ await �[32mIModelApp.telemetry�[37m.postTelemetry(activity, evt);
╵ �[32m~~~~~~~~~~~~~~~~~~~�[0m

�[33m▲ �[43;33m[�[43;30mWARNING�[43;33m]�[0m �[1mmethod "IModelConnection.requestSnap" is internal.�[0m �[1m�[35m[plugin build-studio-app]�[0m

local_path\node_modules\.pnpm\@[email protected]_yeitzudt4omxrstxiyiyjhhfna\node_modules\@itwin\measure-tools-react\lib\esm\tools\MeasureLocationTool.js:91:29:

�[37m 91 │ const result = await �[32mthis.iModel.requestSnap(requestProps)�[37m;
╵ �[32m~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~�[0m

�[33m▲ �[43;33m[�[43;30mWARNING�[43;33m]�[0m �[1minterface "SnapResponseProps" is internal.�[0m �[1m�[35m[plugin build-studio-app]�[0m

local_path\node_modules\.pnpm\@[email protected]_yeitzudt4omxrstxiyiyjhhfna\node_modules\@itwin\measure-tools-react\lib\esm\tools\MeasureLocationTool.js:92:12:

�[37m 92 │ if (�[32mresult.status�[37m !== SnapStatus.Success)
╵ �[32m~~~~~~~~~~~~~�[0m

�[33m▲ �[43;33m[�[43;30mWARNING�[43;33m]�[0m �[1minterface "SnapResponseProps" is internal.�[0m �[1m�[35m[plugin build-studio-app]�[0m

local_path\node_modules\.pnpm\@[email protected]_yeitzudt4omxrstxiyiyjhhfna\node_modules\@itwin\measure-tools-react\lib\esm\tools\MeasureLocationTool.js:101:41:

�[37m 101 │ ...p = new SnapDetail(hit, �[32mresult.snapMode�[37m, result.heat, result.s...
╵ �[32m~~~~~~~~~~~~~~~�[0m

�[33m▲ �[43;33m[�[43;30mWARNING�[43;33m]�[0m �[1minterface "SnapResponseProps" is internal.�[0m �[1m�[35m[plugin build-studio-app]�[0m

local_path\node_modules\.pnpm\@[email protected]_yeitzudt4omxrstxiyiyjhhfna\node_modules\@itwin\measure-tools-react\lib\esm\tools\MeasureLocationTool.js:101:58:

�[37m 101 │ ... SnapDetail(hit, result.snapMode, �[32mresult.heat�[37m, result.snapPoint);
╵ �[32m~~~~~~~~~~~�[0m

�[33m▲ �[43;33m[�[43;30mWARNING�[43;33m]�[0m �[1minterface "SnapResponseProps" is internal.�[0m �[1m�[35m[plugin build-studio-app]�[0m

local_path\node_modules\.pnpm\@[email protected]_yeitzudt4omxrstxiyiyjhhfna\node_modules\@itwin\measure-tools-react\lib\esm\tools\MeasureLocationTool.js:101:71:

�[37m 101 │ ... SnapDetail(hit, result.snapMode, result.heat, �[32mresult.snapPoint�[37m);
╵ �[32m~~~~~~~~~~~~~~~~�[0m

�[33m▲ �[43;33m[�[43;30mWARNING�[43;33m]�[0m �[1minterface "SnapResponseProps" is internal.�[0m �[1m�[35m[plugin build-studio-app]�[0m

local_path\node_modules\.pnpm\@[email protected]_yeitzudt4omxrstxiyiyjhhfna\node_modules\@itwin\measure-tools-react\lib\esm\tools\MeasureLocationTool.js:102:42:

�[37m 102 │ ...urvePrimitive(parseCurve(�[32mresult.curve�[37m), undefined, result.geom...
╵ �[32m~~~~~~~~~~~~�[0m

�[33m▲ �[43;33m[�[43;30mWARNING�[43;33m]�[0m �[1minterface "SnapResponseProps" is internal.�[0m �[1m�[35m[plugin build-studio-app]�[0m

local_path\node_modules\.pnpm\@[email protected]_yeitzudt4omxrstxiyiyjhhfna\node_modules\@itwin\measure-tools-react\lib\esm\tools\MeasureLocationTool.js:102:68:

�[37m 102 │ ...ePrimitive(parseCurve(result.curve), undefined, �[32mresult.geomType�[37m);
╵ �[32m~~~~~~~~~~~~~~~�[0m

�[33m▲ �[43;33m[�[43;30mWARNING�[43;33m]�[0m �[1minterface "SnapResponseProps" is internal.�[0m �[1m�[35m[plugin build-studio-app]�[0m

local_path\node_modules\.pnpm\@[email protected]_yeitzudt4omxrstxiyiyjhhfna\node_modules\@itwin\measure-tools-react\lib\esm\tools\MeasureLocationTool.js:103:26:

�[37m 103 │ if (undefined !== �[32mresult.parentGeomType�[37m)
╵ �[32m~~~~~~~~~~~~~~~~~~~~~�[0m

�[33m▲ �[43;33m[�[43;30mWARNING�[43;33m]�[0m �[1minterface "SnapResponseProps" is internal.�[0m �[1m�[35m[plugin build-studio-app]�[0m

local_path\node_modules\.pnpm\@[email protected]_yeitzudt4omxrstxiyiyjhhfna\node_modules\@itwin\measure-tools-react\lib\esm\tools\MeasureLocationTool.js:104:34:

�[37m 104 │ snap.parentGeomType = �[32mresult.parentGeomType�[37m;
╵ �[32m~~~~~~~~~~~~~~~~~~~~~�[0m

�[33m▲ �[43;33m[�[43;30mWARNING�[43;33m]�[0m �[1minterface "SnapResponseProps" is internal.�[0m �[1m�[35m[plugin build-studio-app]�[0m

local_path\node_modules\.pnpm\@[email protected]_yeitzudt4omxrstxiyiyjhhfna\node_modules\@itwin\measure-tools-react\lib\esm\tools\MeasureLocationTool.js:105:26:

�[37m 105 │ if (undefined !== �[32mresult.hitPoint�[37m)
╵ �[32m~~~~~~~~~~~~~~~�[0m

�[33m▲ �[43;33m[�[43;30mWARNING�[43;33m]�[0m �[1minterface "SnapResponseProps" is internal.�[0m �[1m�[35m[plugin build-studio-app]�[0m

local_path\node_modules\.pnpm\@[email protected]_yeitzudt4omxrstxiyiyjhhfna\node_modules\@itwin\measure-tools-react\lib\esm\tools\MeasureLocationTool.js:106:38:

�[37m 106 │ ...ap.hitPoint.setFromJSON(�[32mresult.hitPoint�[37m); // Update hitPoint f...
╵ �[32m~~~~~~~~~~~~~~~�[0m

�[33m▲ �[43;33m[�[43;30mWARNING�[43;33m]�[0m �[1minterface "SnapResponseProps" is internal.�[0m �[1m�[35m[plugin build-studio-app]�[0m

local_path\node_modules\.pnpm\@[email protected]_yeitzudt4omxrstxiyiyjhhfna\node_modules\@itwin\measure-tools-react\lib\esm\tools\MeasureLocationTool.js:107:26:

�[37m 107 │ if (undefined !== �[32mresult.normal�[37m)
╵ �[32m~~~~~~~~~~~~~�[0m

�[33m▲ �[43;33m[�[43;30mWARNING�[43;33m]�[0m �[1minterface "SnapResponseProps" is internal.�[0m �[1m�[35m[plugin build-studio-app]�[0m

local_path\node_modules\.pnpm\@[email protected]_yeitzudt4omxrstxiyiyjhhfna\node_modules\@itwin\measure-tools-react\lib\esm\tools\MeasureLocationTool.js:108:44:

�[37m 108 │ snap.normal = Vector3d.fromJSON(�[32mresult.normal�[37m);
╵ �[32m~~~~~~~~~~~~~�[0m

�[33m▲ �[43;33m[�[43;30mWARNING�[43;33m]�[0m �[1mmethod "AccuDrawHintBuilder.setRotation" is internal.�[0m �[1m�[35m[plugin build-studio-app]�[0m

local_path\node_modules\.pnpm\@[email protected]_yeitzudt4omxrstxiyiyjhhfna\node_modules\@itwin\measure-tools-react\lib\esm\tools\MeasureAreaTool.js:94:20:

�[37m 94 │ �[32mhints.setRotation(mat.inverse())�[37m;
╵ �[32m~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~�[0m

The text was updated successfully, but these errors were encountered:

simnorm changed the title ~~measure-tools-react "AccuDrawHintBuilder.setRotation" is internal~~ measure-tools-react review and fix internal api usage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment