Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Models tree: Allow ruleset customization #711

Open
grigasp opened this issue Dec 13, 2023 · 2 comments
Open

Models tree: Allow ruleset customization #711

grigasp opened this issue Dec 13, 2023 · 2 comments
Labels
enhancement New feature or request tree widget Tree widget or its components related issues

Comments

@grigasp
Copy link
Member

grigasp commented Dec 13, 2023

At the moment there's no way to customize the Models Tree hierarchy. The specific requirement is to add additional rules to load additional child nodes for specific types of geometric elements.

The custom ruleset may create nodes that we don't know how to handle. Need to ensure:

  • It's possible to provide such a visibility handler that can handle those custom nodes.
  • The component behaves expectedly when visibility handler does not handle such nodes - the created node should simply not provide any visibility cues or controls.
  • Documentation is clear on:
    • The kind of nodes ModelsTreeVisibilityHandler expects and how to create similar ones through custom rules.
    • What happens if a custom node that's not handled by default visibility handler is returned.
    • What needs to be done to implement visibility handling for custom nodes.
@grigasp grigasp added enhancement New feature or request tree widget Tree widget or its components related issues labels Dec 13, 2023
@GintV
Copy link

GintV commented May 28, 2024

@1abjora @grigasp Any news on this one? Maybe this could be scheduled for upcoming future? Or we could make a contribution that enables custom processing of current rules (minimal changes required). We could mark it as experimental/internal so that anyone that uses additional props on ModelsTree know that this might break at any point?

@grigasp
Copy link
Member Author

grigasp commented May 28, 2024

@1abjora @grigasp Any news on this one? Maybe this could be scheduled for upcoming future? Or we could make a contribution that enables custom processing of current rules (minimal changes required). We could mark it as experimental/internal so that anyone that uses additional props on ModelsTree know that this might break at any point?

We're in the process of rewriting the tree widget to not use presentation rules and I'd hate to spend time changing the components we're about to deprecate. If you have the necessary changes, please set up a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tree widget Tree widget or its components related issues
Projects
None yet
Development

No branches or pull requests

2 participants