Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Schema.org tests should work with nested objects #19

Open
iaincollins opened this issue Mar 14, 2020 · 2 comments
Open

New Schema.org tests should work with nested objects #19

iaincollins opened this issue Mar 14, 2020 · 2 comments
Labels
bug Something isn't working pre-release Issues that do not impact the live version, only the pre-release version
Milestone

Comments

@iaincollins
Copy link
Owner

Describe the bug
The new Schema.org property tests - that check if property names valid or not - should work with nested objects.

Note: Applies to the new Schema.org property tests are in master but not in the release version.

To Reproduce
Nested property names (ie any property that is not a top level property) are not currently checked for validity. See existing invalid properties fixture for an example of an error that is not caught (only some of the errors in the example are caught by the current tests).

Expected behaviour
Nested property names should be checked to see if they are valid and should raise an error if they are not valid on a nested property. This might prove tricky to implement as some properties can be one of many different types and that might complicate the logic.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

@iaincollins iaincollins added the bug Something isn't working label Mar 14, 2020
@iaincollins iaincollins added this to the Version 5.0 milestone Mar 14, 2020
@iaincollins iaincollins added the pre-release Issues that do not impact the live version, only the pre-release version label Mar 14, 2020
iaincollins added a commit that referenced this issue Mar 14, 2020
Refactor to improve maintainability, inadvertantly found and fixed bugs in the process (tests updated accordingly).

Works towards resolving #19
@lordscarlet
Copy link

Note: Applies to the new Schema.org property tests are in master but not in the release version.

Does this mean this bug is not present in v4.5?

@iaincollins
Copy link
Owner Author

Can confirm yes this bug is not in the currently released version just in the master version - the current version does not check property names for validity at all (just reports what it finds).

This is my fault for merging the work for the next release (5.0) into master instead of pushing to a separate branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pre-release Issues that do not impact the live version, only the pre-release version
Projects
None yet
Development

No branches or pull requests

2 participants