add import json tests #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the main error blocking this branch is reproduced here https://github.com/iambumblehead/nodejs-import-attributes-repro |
|
Possibly, if the issue were reported upstream now, it would be de-prioritized and forgotten because of the experimental state of import attributes. Therefore, it might be better to wait and create an issue later when import attributes are more stable. |
|
This PR enables mocking of imported json files and can hang out here for a few weeks. A commented-out test here fails, because of an acknowledged bug at nodejs upstream. @koshic @Swivelgames if you are available, please review and give your opinion. |
koshic
approved these changes
Sep 24, 2023
iambumblehead
force-pushed
the
add-import-json-test
branch
3 times, most recently
from
ce2e7e2 to
c5eb9ea
Compare
|
the test only passes in node 21 upstream issue was resolved but maybe the solution has not been ported to node 18 or 20 yet |
iambumblehead
force-pushed
the
add-import-json-test
branch
from
bdf3eab to
913c105
Compare
…tream issue is resolved those
iambumblehead
force-pushed
the
add-import-json-test
branch
from
cacdfa4 to
97993ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re #246
On first implementation, there is an issue. When multiple tests are added around this feature, they fail. Nodejs returns only the first-resolved json result to many callers., even though each mocked-json is requested through its own unique uri.