Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync source code with released code #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
120 changes: 120 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -0,0 +1,120 @@
2017-04-03 KSK Rollover

Version 20170403

* Changes to the KSR Signer “ksrsigner” component:

1. ksrsigner/ksrcommon.c:
a. Added support to process the configuration file “kskschedule.json”.
b. Added support to process the configuration options to sign, publish
or revoke the KSK.

2. ksrsigner/ksrcommon.h:
a. Added definition of json key schedule parsing support.

3. ksrsigner/ksrsigner.c:
a. Added support to locate the configuration file kskschedule.json in the same
place as the KSR.xml file.

4. ksrsigner/wksr.c:
a. Added support to locate the configuration file kskschedule.json in the same
place as the KSR.xml file.

* Other changes:

5. utils/printlog:
a. Removed top margin.
b. Added header with name and page.
c. Reduced font size to fit better on the page.

6. utils/hsmfd-hash:
a. New bash script to calculate, print and compare hashes for HSMFDs.

7. ChangeLog:
a. Added a change log file.

8. README.md:
a. Update copyright year to 2017


2016-10-12 RSSAC003 Recommendation

Version 20161012

* Changes to the KSR Signer “ksrsigner” component:

1. ksrsigner/ksrpolicy.h:
a. Changed the signature validity period to 21 days.
b. Changed the maximum signature validity to 21 days.
c. Changed the minimum signature validity to 21 days.
d. Changed the maximum signature validity overlap to 16 days.
e. Changed the minimum signature validity overlap to 9 days.

* Changes to the KSK Generator “kskgen” component:

2. kskgen/kskparams.h:
a. Changed the certificate signing request Organization (O) from ICANN to
Public Technical Identifiers (PTI) to reflect the organization PTI as the
new Root Zone KSK Operator.
b. Changed the certificate signing request Organization Unit (OU) to
Cryptographic Business Operations.

* Other changes:

3. common/logger.c
a. Fixed the misspelled word “fatal”.
b. Fixed the misspelled word “warning”.

4. common/pkcs11_dnssec.c
a. Changed a warning message in case there is not private key match.


2016-04-19 ZSK Length Change

Version 20160419

* Changes to the KSR Signer “ksrsigner” component:

1. ksrsigner/ksrcommon.c
2. ksrsigner/ksrcommon.h
3. ksrsigner/ksrpolicy.h
4. ksrsigner/ksrsigner.c
5. ksrsigner/wksr.c

a. Added support for multiple SignatureAlgorithm fields and check
the field on incoming KSR against actual key material and match fields
outgoing SKR. Specifically it was discovered that neither ICANN nor
Verisign were inspecting RequestPolicy or ResponsePolicy sections of
the KSR-SKR XML exchange. This was evidenced by the incorrect key
exponent “3” being passed back and forth since the first key ceremony
when it should have been “65537”. This had no effect on operations.
However, it does not meet the specifications originally laid out.
b. Added tests for other fields in the ksr.xml fields including:
Exponent length, SignatureAlgorithm and keytag.
c. Removed tests that limited acceptable KSR formats to allow for
extended single ZSK use across KSRs.


2011-09-21 180 Days Warning

Version 20110921

Allowed signings prior to 180 days from signature expiration. The idea
is to keep the 180-day validation but to replace the error (signing
interception) with a warning so that the signing could still be
completed.


2010-10-29 x509 Schema

Version 20101029

Changed to x509 schema.


2010-06-12 Original

Version 20100612

First version.

6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
# ICANN DNSSEC Key Tools

This repository contains source code for the software used by IANA to manage
This repository contains source code for the software used by PTI to manage
the DNSSEC Key Signing Key (KSK) for the Root Zone.

More information about Root Zone Management is available at
http://www.iana.org/domains/root.
https://www.iana.org/domains/root.

## License

Copyright (c) 2010-2013 Internet Corporation for Assigned Names and
Copyright (c) 2010-2017 Internet Corporation for Assigned Names and
Numbers ("ICANN")

Permission to use, copy, modify, and/or distribute this software for any
Expand Down
4 changes: 2 additions & 2 deletions common/logger.c
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ static const char *logfile_timeformat = "%Y%m%d-%H%M%S";
static const char *logentry_timeformat = "%Y-%m-%dT%H:%M:%SZ";
static char logfile_fname[MAXPATHLEN];

/*! emit fata error message with decoded error number and exit
/*! emit fatal error message with decoded error number and exit

\param message optional message string to incorporate into display
*/
Expand Down Expand Up @@ -74,7 +74,7 @@ static const char *pri2str(int pri)
if (pri == LOG_ALERT) return "alert";
if (pri == LOG_CRIT) return "critical";
if (pri == LOG_ERR) return "error";
if (pri == LOG_WARNING) return "waring";
if (pri == LOG_WARNING) return "warning";
if (pri == LOG_NOTICE) return "notice";
if (pri == LOG_INFO) return "info";
if (pri == LOG_DEBUG) return "debug";
Expand Down
2 changes: 1 addition & 1 deletion common/pkcs11_dnssec.c
Original file line number Diff line number Diff line change
Expand Up @@ -850,7 +850,7 @@ int pkcs11_getpub(char *label,char *id,mbuf *mod,mbuf *exp,void *vdc[],int kmax)
if((rv=pfl->C_FindObjectsFinal(sh)) != CKR_OK) goto nopriv;
if(i <= 0) {
nopriv:
logger_warning("No matching private key for %s/%s in HSM %s slot %d",kr->label->p0,kr->id->p0,pk->lib,pk->slot);
logger_warning("No matching private key for %s in HSM %s slot %d",kr->label->p0,pk->lib,pk->slot);
} else {
kr->hkp = (void *)hPrivKeys[0];
}
Expand Down
4 changes: 2 additions & 2 deletions kskgen/kskparams.h
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@
/*
* Certificate Request Subject
*/
#define DN_O "ICANN" /*!< Organization */
#define DN_OU "IANA" /*!< Organization Unit */
#define DN_O "Public Technical Identifiers" // was "ICANN" /*!< Organization */
#define DN_OU "Cryptographic Business Operations" // was "IANA" /*!< Organization Unit */
#define DN_EMAIL "[email protected]" /*!< Email Address */
#define OID_DNS "1.3.6.1.4.1.1000.53" /*!< Enterprise specific DNS OID */

Expand Down
Loading