Merge branch '2.3' of ezsystems/ezplatform-admin-ui into 4.5

[ezrobot]

Cross merge PR

[barw4]

@bogusez I think we should test this on v4.5 just to be on the safe side

[bogusez]

@bogusez I think we should test this on v4.5 just to be on the safe side

Ok, I'm on it.

[bogusez]

@barw4
JS exception issue gone but now we have an issue with notification. See more details on attached screenshot

[barw4]

Thanks, will take a look

[barw4]

@bogusez did you run the composer run post-install-cmd command after applying the patch?

[bogusez]

@bogusez did you run the composer run post-install-cmd command after applying the patch?

yes, I did. I will try it again.

[bogusez]

@barw4 I have reinstalled the environment and I have the same issue. Tested both ways with cloned branch and patched changes (in both cases composer run post-install-cmd run after installing changes).
Tested on v4.5.x-dev

Edit: assets also rebuilt after applying changes. Doesn't help to solve the problem.

[barw4]

@bogusez can you validate if it works now?

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[bogusez]

@barw4 now we have a different notification message.

[bogusez]

@barw4 now we have a different notification message.

I think it is the same notification as before but now with correct translation.

[barw4]

@bogusez so all is good? The message is correct from my point of view.

[bogusez]

@bogusez so all is good? The message is correct from my point of view.

The expected result in the task description says:

Expected There should be no error and possibly information about the lack of an image in the content

How should we interpret it?

[barw4]

? But this is behaving exactly the same as in merged 3.3 you tested?

[bogusez]

? But this is behaving exactly the same as in merged 3.3 you tested?

Not exactly the same, on 3.3 version there wasn't any notification that chosen asset has no image file attached. I was able to publish the content with selected image content which doesn't contains image file.

[barw4]

@bogusez please, see the PR's description and title ezsystems/ezplatform-admin-ui#2116

[bogusez]

@bogusez please, see the PR's description and title ezsystems/ezplatform-admin-ui#2116

so we have discrepancies because expected result in task description says completely different thing or maybe I understood it wrong?

[barw4]

It says exactly the same thing. Mateusz's description mentioned that there is JS error in the console, he attached a screenshot of it.

There should be no error and possibly information about the lack of an image in the content

The JS error is gone and you have information about lack of an image.

[bogusez]

? But this is behaving exactly the same as in merged 3.3 you tested?

@barw4 my bad, the notification on v3.3 also appears. Everything is clear now.