IBX-8506: Disabled display_errors in Cloud #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwojs
approved these changes
Jul 8, 2024
konradoboza
approved these changes
Jul 9, 2024
|
Hi! Please note that it expands on what's in #77 - I believe only one of these PRs should be merged (and this one seems to add more "sane defaults"? 🤔 ) |
|
Oh dang, I didn't know. WDYT @mateuszbieniek? PHP says "It's strongly recommended to keep display_startup_errors off, except for debugging." And I think it's good to have a comment about why we're setting them. |
|
I think you are right and I'm OK with dropping my PR in favor of this one :) (also checked, and yes, in p.sh envs this is also set to "on" by default) |
|
Thanks, good to know, that's not a great default on their side. |
webhdx
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
The PHP config for Ibexa Cloud should default to not display errors in production. This is normally of no consequence as Symfony controls error handling, but in exceptional situations Symfony may fail and PHP's error handling take over. So to be on the safe side the default should be to not display errors.
For QA:
See Doc note below. And note that you will have to crash Symfony to reproduce the change.
Documentation:
See related doc PR (merged). Note also that these config files do not detect prod/dev mode, so display_errors will now by default be disabled regardless of mode, this should be noted in release notes.
Note