-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log failed itin checks and bus notifs #263
Merged
Merged
Changes from 3 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
9c1027f
refactor(CheckMonitoredTrip): Log instances where no matching itinera…
binh-dam-ibigroup 3418ef8
refactor(UsRideGw...Operator): Log before sending bus notifications.
binh-dam-ibigroup 9b4115f
refactor(CheckMonitoredTrip): Dump comparison itinerary data.
binh-dam-ibigroup aa05049
refactor(CheckMonitoredTrip): Add trip id in logs, log null OTP respo…
binh-dam-ibigroup 111af9b
refactor(BusOpAction): Add log to confirm actions.
binh-dam-ibigroup 878c54c
fix(ItineraryUtils): use OTP2 objects.
binh-dam-ibigroup 4f1dc85
ci(mnaven): Temp remove e2e tests
binh-dam-ibigroup dcfcbf6
fix(ItineraryUtils): Use Otp2 stop gtfsid
binh-dam-ibigroup a8fcae4
refactor(ItineraryExistence): Log failed day-of itinerary checks.
binh-dam-ibigroup 967e6f3
fix(MonitoredTripController): Tolerate not-found trips after saving/e…
binh-dam-ibigroup 935558d
fix(ItineraryExistence): Tweak error message about non-existent itine…
binh-dam-ibigroup 24a20c6
fix(ItineraryExistence): Remove \\n from error message about non-exis…
binh-dam-ibigroup de0922d
Merge branch 'dev' into log-failed-itin-checks-and-bus-notifs
binh-dam-ibigroup 22423f8
refactor(ItineraryExistence): Tweak error message for trip not possible.
binh-dam-ibigroup b937857
Revert "ci(mnaven): Temp remove e2e tests"
binh-dam-ibigroup ccbde41
refactor(ItineraryExistence): Extract method for logging itins not fo…
binh-dam-ibigroup bebd4e9
style(ItineraryExistence): Add full stops and address indents.
binh-dam-ibigroup 6f0de6e
refactor(ItineraryExistence): Combine 3 log statements into one.
binh-dam-ibigroup File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,6 +19,7 @@ | |
import org.opentripplanner.middleware.utils.DateTimeUtils; | ||
import org.opentripplanner.middleware.utils.I18nUtils; | ||
import org.opentripplanner.middleware.utils.ItineraryUtils; | ||
import org.opentripplanner.middleware.utils.JsonUtils; | ||
import org.opentripplanner.middleware.utils.NotificationUtils; | ||
import org.slf4j.Logger; | ||
import org.slf4j.LoggerFactory; | ||
|
@@ -301,7 +302,9 @@ private boolean makeOTPRequestAndUpdateMatchingItineraryInternal() { | |
} | ||
|
||
// If this point is reached, a matching itinerary was not found | ||
LOG.warn("No comparison itinerary found in otp response for trip"); | ||
LOG.warn("No comparison itinerary found in otp response for trip - params: {}", JsonUtils.toJson(this.trip.otp2QueryParams)); | ||
LOG.warn("No comparison itinerary found in otp response for trip - saved itinerary: {}", JsonUtils.toJson(this.trip.itinerary)); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit. |
||
LOG.warn("No comparison itinerary found in otp response for trip - OTP itineraries: {}", JsonUtils.toJson(otpResponse.plan.itineraries)); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should this guard against a NPE in case plan is null? |
||
|
||
if (hasReachedMaxItineraryChecks()) { | ||
// Check whether this trip should no longer ever be checked due to not having matching itineraries on any | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit.
this.
is not needed.