Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text is blank on iOS Safari/chrome #2

Open
refazi opened this issue Jan 12, 2022 · 29 comments
Open

Text is blank on iOS Safari/chrome #2

refazi opened this issue Jan 12, 2022 · 29 comments
Labels
bug Something isn't working

Comments

@refazi
Copy link

refazi commented Jan 12, 2022

When using mobile browser like safari or chrome in iOS, the text is blank - looks like the characters are colored the same as the background.

@AaronDewes
Copy link
Contributor

AaronDewes commented Jan 12, 2022

What version are you using? Buster (Umbrel) or Bullseye (Citadel)?

@refazi
Copy link
Author

refazi commented Jan 12, 2022

Citadel

@ibz
Copy link
Owner

ibz commented Jan 12, 2022

Could be related to this: tsl0922/ttyd#798

What iOS version are you using?

@refazi
Copy link
Author

refazi commented Jan 12, 2022

Yeah the issue looks similar, I’m on 15.2

@ibz
Copy link
Owner

ibz commented Jan 14, 2022

It's been over a year since ttyd released a new version. Others are also asking for a new release tsl0922/ttyd#784

I could try building it from master, though I don't really like that approach.

What do you think, @AaronDewes ?

@AaronDewes
Copy link
Contributor

That would mean reverting some changes for bullseye in generate-dockerfile.sh, but it sounds like a good idea.

@ibz
Copy link
Owner

ibz commented Jan 14, 2022

Hey @AaronDewes, I've made a new build with the last ttyd (on master). Could you try it on Citadel and confirm that the issue is fixed? If so, I will create a new tag and close the issue.

@AaronDewes
Copy link
Contributor

I've published the new version to Citadel, but can't test it myself, @refazi it'd be great if you could try with the update apps button and waiting a few minutes.

@refazi
Copy link
Author

refazi commented Jan 14, 2022

I updated twice, the version in the App Store shows as 1.1.1, still have the same issue.

@AaronDewes
Copy link
Contributor

Can you try to SSH in and run ~/citadel/events/triggers/app-update

@ibz
Copy link
Owner

ibz commented Jan 14, 2022

@AaronDewes is the SHA256 in app.yaml the correct one though? I am trying to run that container on my Umbrel and can't.

This one, I mean runcitadel/apps@edf35a0

@AaronDewes
Copy link
Contributor

Thanks, that was the problem. Looks like I had another sha256 copied and pasted that by accident

@refazi
Copy link
Author

refazi commented Jan 14, 2022

The app doesn’t seem to start, the docker log on syslog says “manifest unknown”

@ibz
Copy link
Owner

ibz commented Jan 15, 2022

I think this is getting a bit confusing now, with so many versions flying around. I've created version 0.1.3 of lightning-shell and submitted a pull request to @runcitadel. Ideally we will be using tagged versions, not builds from master.

@refazi
Copy link
Author

refazi commented Jan 15, 2022

I still see an issue, the COI toner in version 0.1.3 doesn’t come up, I see the following error on the container log:
Standard_init_linux.go:228: exec user process caused exec format error

@ibz
Copy link
Owner

ibz commented Jan 15, 2022

Hmm, that is strange, that error should show up when you try to run a container built for the wrong architecture - like running the amd64 container on the Pi.

But the SHA in https://github.com/runcitadel/apps/blob/main/apps/lightning-shell/app.yml matches the SHA of the ARM64 build on https://github.com/ibz/lightning-shell/pkgs/container/lightning-shell/13252298?tag=v0.1.3-bullseye-slim .

Is there any other place where you are storing the image reference/SHA, @AaronDewes ? Or can it be that he did not update to the last yml?

Or ... are you running Citadel on something else than Raspberry Pi @refazi ?

Other than that, I don't understand how this would happen.

@refazi
Copy link
Author

refazi commented Jan 16, 2022

Yeah it’s running on x86, can you build it for that arch as well?

@ibz
Copy link
Owner

ibz commented Jan 16, 2022

Yeah, v0.1.3 was built for x86 as well, but I wrongly added the SHA256 of the ARCH build (thinking Citadel is only used on Raspberry Pi, silly me).

I think @AaronDewes fixed it by now.

@AaronDewes
Copy link
Contributor

I fixed it, but even after my PR to add a missing dependency, it's still broken. I'll debug it further

@refazi
Copy link
Author

refazi commented Jan 18, 2022

Btw I just installed the umbrel version via the umbrel 0.4.11 release and I have the same issue

@ibz
Copy link
Owner

ibz commented Jan 18, 2022

Yes, Umbrel has the old version. I submitted to them before the fix. :)

@ibz
Copy link
Owner

ibz commented Jan 18, 2022

@AaronDewes I just had a look at your app.yaml, it seems like you are using a build from master, that may be broken (master is sometimes broken).

You should be using v0.1.3, which works fine on my Umbrel.

@ibz
Copy link
Owner

ibz commented Jan 18, 2022

Ha! I found something...

I think it's only the Bullseye image that is broken (libwebsockets fails to load evlib_uv for some reason) whereas the Buster image works fine. Hence it worked for me on Umbrel (using Buster).

I'll investigate further and come up with a fix, but before that, to summarize...

  • Using the version currently on Umbrel (0.1.1) will work, but iOS will be broken.
  • Using 0.1.3 should fix iOS (in theory - I did not test it yet) - but this build is broken on Bullseye and the Buster build not released on Umbrel yet.

As a temporary fix:

  • on Umbrel, you could upgrade to 0.1.3 (Buster) by manually editing app.yaml and relaunching.
  • on Citadel - could we try to run 0.1.3 Buster rather than Bullseye?

@AaronDewes
Copy link
Contributor

Sure, I'll try to go back to buster.

@ibz
Copy link
Owner

ibz commented Jan 18, 2022

@AaronDewes I think the issue was this after all 4c53e09#diff-5be359434de5b83c3988bbf1494c1dab5bb8110cf7141650fec0e06e02d4b1dcR102

Should be fixed now in master. I'll make a tag soon also.

@ibz
Copy link
Owner

ibz commented Jan 23, 2022

BTW, v0.1.4 is released. I just submitted it to Umbrel. Could we add that to Citadel as well?

@refazi
Copy link
Author

refazi commented Jan 23, 2022

Updated to citadel 0.5.20 and 0.1.4 seems to be there.
The app loads and the browser experience is great, but I still have the same issue with the mobile browsers via iOS

@ibz
Copy link
Owner

ibz commented Jan 23, 2022

@refazi Thanks for double checking! Too bad... OK, we'll leave this issue open then for now.

@ibz ibz added the bug Something isn't working label Jan 23, 2022
@editwentyone
Copy link

this is still an open bug on safari iOS or macOS with lightning shell 1.1.0 on citadel 0.0.2

the guys over at unraid.com had also such an visual bug with the terminal shell, but I couldn't find how they fixed it. all I can tell is, its working there.

Bildschirmfoto 2022-05-09 um 13 34 41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants