Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging in StatusCheck timer #436

Closed
brianritchie1312 opened this issue Jun 4, 2019 · 2 comments
Closed

Improve logging in StatusCheck timer #436

brianritchie1312 opened this issue Jun 4, 2019 · 2 comments

Comments

@brianritchie1312
Copy link
Contributor

StatusCheck.poll() currently catches and logs any Exceptions; but logs only the original message. It would be more useful if it added a more specific indication to the message.
Similarly, determining the cause of an expunged timer thread in glassfish can be difficult. I propose adding a catch-log-and-rethrow for all other Throwables. This is not considered good practice generally, but may improve traceability.
See also: icatproject/icat.utils#8 (comment)

@brianritchie1312
Copy link
Contributor Author

I stand corrected on the first part of this: errors logged to topcat.log do indicate that they are from StatusCheck; so there is no need to add extra text to the log message.
I have some evidence that suggests they still count as failures that may trigger glassfish to expunge the timer.

@brianritchie1312
Copy link
Contributor Author

8d7984c added logging to StatusCheck to record prepareData and isPrepared requests on the IdsClient and any resulting changes to Download status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant