Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify trust level to be larger than 1/3 on tendermint client creation. #810

Closed
AntonAndell opened this issue Jan 3, 2024 · 0 comments · Fixed by #828
Closed

Verify trust level to be larger than 1/3 on tendermint client creation. #810

AntonAndell opened this issue Jan 3, 2024 · 0 comments · Fixed by #828
Assignees
@AntonAndell
Labels
iBriz iBriz Team ICON ICON Chain related task

Comments

@AntonAndell
Copy link
Collaborator

Current we allow trustlevel to be any fractions which could create a trustlevel that is invalid in tendermint.
For more details see audit report.
@AntonAndell AntonAndell added iBriz iBriz Team ICON ICON Chain related task labels Jan 3, 2024
@AntonAndell AntonAndell linked a pull request Jan 23, 2024 that will close this issue
fix: Require tendermint clientstate trustlevel to be >= 1/3 #828
Merged
8 tasks
@AntonAndell AntonAndell self-assigned this Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AntonAndell AntonAndell

Labels
iBriz iBriz Team ICON ICON Chain related task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Require tendermint clientstate trustlevel to be >= 1/3 icon-project/IBC-Integration
2 participants
@AntonAndell @pragyanshrestha-ibriz