Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"I&C SCI 46" Should be the first result for the search "ICS 46", not on page 3 #456

Closed
Awesome-E opened this issue Mar 5, 2024 · 2 comments
Closed

"I&C SCI 46" Should be the first result for the search "ICS 46", not on page 3 #456

Awesome-E opened this issue Mar 5, 2024 · 2 comments

Comments

@Awesome-E
Copy link
Member

Reproduce:

  1. Search for "ICS 46"

Expected: I&C SCI 46 (Data structure implementation + analysis) shows as the first result
Actual: the course number seems to take higher priority even when not a full match, causing ICS 46 to show on page 3 for an exact search
@js0mmer
Copy link
Member

js0mmer commented Mar 5, 2024

Interesting. Never noticed this since I've never capitalized, just searched up "ics 46" which works. Short term fix is to convert query to lower case before calling websoc fuzzy search.

In the future, fuzzy search will be reworked. icssc/peterportal-api-next#131

@js0mmer
Copy link
Member

js0mmer commented Nov 15, 2024

fixed by #505

@js0mmer js0mmer closed this as completed Nov 15, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in PeterPortal Client Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
PeterPortal Client
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@js0mmer @Awesome-E