Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split GitHub workflows #528

Merged
merged 8 commits into from
Dec 9, 2024
Merged

Split GitHub workflows #528

merged 8 commits into from
Dec 9, 2024

Conversation

js0mmer
Copy link
Member

@js0mmer js0mmer commented Dec 7, 2024 •
edited
Loading

Description

  • Split build and deploy workflow for prod and staging
  • Created actions for repeated steps
  • Fixed concurrency groups
  • Added condition to not deploy staging on fork

Steps to verify/test this change:

  • Verify changes work as expected on staging instance

Final Checks:

  • Verify successful deployment

(optional)

  • Write tests
  • Write documentation

Followup

  • Update the status check in the branch protection settings for main to replace the old build and deploy workflow with the new one

Issues

Closes #499, closes #491

@js0mmer js0mmer temporarily deployed to staging-528 December 7, 2024 01:32 — with GitHub Actions Inactive
@js0mmer js0mmer temporarily deployed to staging-528 December 7, 2024 01:34 — with GitHub Actions Inactive
@js0mmer js0mmer temporarily deployed to staging-528 December 7, 2024 01:38 — with GitHub Actions Inactive
@js0mmer js0mmer temporarily deployed to staging-528 December 7, 2024 01:45 — with GitHub Actions Inactive
@js0mmer js0mmer closed this Dec 7, 2024
@js0mmer js0mmer reopened this Dec 7, 2024
@js0mmer js0mmer temporarily deployed to staging-528 December 7, 2024 01:54 — with GitHub Actions Inactive
@js0mmer js0mmer temporarily deployed to staging-528 December 7, 2024 02:06 — with GitHub Actions Inactive
@js0mmer js0mmer marked this pull request as ready for review December 7, 2024 02:07
@js0mmer js0mmer requested a review from Awesome-E December 7, 2024 02:08
@js0mmer js0mmer temporarily deployed to staging-528 December 9, 2024 22:33 — with GitHub Actions Inactive
@js0mmer js0mmer merged commit b966cb5 into main Dec 9, 2024
2 checks passed
@js0mmer js0mmer deleted the split-github-workflows branch December 9, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Awesome-E Awesome-E Awesome-E approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate actions workflows Staging deploy fails for PRs from forks
2 participants
@js0mmer @Awesome-E