Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the 2foc procedure #46

Closed
valegagge opened this issue Jul 29, 2024 · 5 comments
Closed

Check the 2foc procedure #46

valegagge opened this issue Jul 29, 2024 · 5 comments
Assignees

Comments

@valegagge
Copy link
Member

The supplier www.mwfep.com complaints regarding the USB CAN driver.

We provided the mini USB CAN device that needs a driver that is no longer available on the ESD site.
Verify if the procedure provides the correct driver. If not we need to update the kit cod.4569.E - 2FOC_ADC, IIT - Testing equipment for 2FOC boards with the newest CAN device.

Dod
The procedure is correct

@MSECode
Copy link
Member

MSECode commented Aug 5, 2024

Hi all,
regarding the 2foc procedure that the supplier mwfep is doing for us we have encountered some issues. Some of them, the one related to the CAN device have been solved, but we still have problem in the finalizing of the whole tests procedure. Specifically the following tests are failing:

  • test I su ponte CH 1
  • test I su ponte CH 2
  • test protezione di corrente su CH 1
  • test protezione di corrente su CH 2

These test are related to the check of the current flow through the MOSFETs after the hw modification done in the version K of the 2foc.
However, looking at the test logs sent by the supplier and available here: 2FOC sn2 29-7-2024 10.46.20 N8.txt
I can see that on the tests test I su ponte CH 1 and test I su ponte CH 2 we have an error that tells that the current flowing is lower than the minor threshold.
Therefore, there might be some tests with the tests procedure or with the boards themselves since all the other tests are passing positively and the only modifications that have been done on the last release are actually related to those tests where we have increased the threshold to tests the version K of the 2foc.
This, considering that the emails thread is becoming hard to follow and that we do not have a clear idea of the problem, following @maggia80 suggestion, I'm gonna ask them to double-check the procedure with the previous v1.0.3 test release and then send back the whole test equipment so that we can check the tests of the latest version by ourselves.
Moreover, I asked them if they tested the procedure using different 2foc boards and also the golden board. If that is the case, the best option, I suppose, is to do as written above.
Let me know what do you think. If it is reasonable for you, I'm gonna send them an email suggesting that.

cc: @Fabrizio69 @valegagge @fgarini @maurizbo @maggia80

@MSECode
Copy link
Member

MSECode commented Sep 27, 2024

Here the update

Yesterday with @fgarini and @AntonioAzocar we run the whole procedure for testing the 2foc boards using the equipment given back by mwfep with code 2FOC cod. 4569 and here I'll report some notes regarding what done:

  • first of some of the procedure steps, even if they are all correct in what they do, should be revised
  • when using the goldenboard it is impossible to run the whole procedure with the same board and this is a problem since in the second phase the test bootloader and fw are not flashed at the beginning of the procedure, so that should be added as mentioned at the point above
  • the board without the TH components in the test equipment should be changed or labeled with a SN
  • all the tests of the procedure done with the goldenboard have been passed successfully, thus we sent an email to mwfep to ask them for checking the top and bottom of the 2foc boards they produced since they might be forgot to follow some of the assembly notes
  • I suppose that they did not run the test procedure using the goldenboard
  • On top of this, I need to mentioned that w/ @Fabrizio69 we found out that there has been a switch of serial number for the 2 2foc board with SN:1561 and SN:1573(goldenboard), so I'd check the others as well
  • I'd like to fix the test equipment I've with me thus to try to assemble a second equipment to make easier to support who is gonna make the tests on the boards for us

Thus, we are just waiting for the reply from https://mwfep.com/it/ regarding the produced 2foc boards and the assembly notes. In the meanwhile I'd like to have a meeting to discuss regarding what to do with:

  • the current test equipment, which should be eventually sent to them for finalizing the tests
  • the 2foc boards with the erroneous SN
  • the old equipment that can be fixed

cc: @valegagge @maggia80

@MSECode
Copy link
Member

MSECode commented Sep 30, 2024

As per discussion w/ @valegagge, we will organize a meeting to discuss about the issues raised in the first 2 point of this comment, which can be summarized in the following bullet list (I'll mentioned just the topics, further details will be discussed during the meeting ):

  • second part of the test run cannot be run standalone with the goldenboard as it is but we need to add the flash of the test fw
  • the first part of the test procedure cannot be run with the goldenboard but we need a "goldenboard with no TH components"
  • we need to update some of the lines in the instructions of the test procedure since now we are not only using 2FOC rev C and D but also earlier versions
  • label the "goldenboard with no TH" present in the test suite or change it

@MSECode
Copy link
Member

MSECode commented Oct 25, 2024

Action points

Problem Solution Action point Link to issue
Procedure instructions to be solved Remove board revision from instructions and add reference to the Logic (ex. J1) --> WIP @MSECode and @fgarini need to check this and @MSECode updates the procedure instructions #48
Phase2 of the procedure does not flash the test fw, thus problem when using the GOLDENBOARD Add flash of bl and test fw at the beginning of phase 2 @MSECode will add and @AntonioAzocar will run the whole procedure to check for problems #49
Missing labelling for GOLDENBOARD without the TH Substitute the GOLDEN without TH with a new one and label this as GOLDENBOARD without THT @Fabrizio69 will create the entry for the warehouse #50
Problems will silicon version during phase 1 of the test for some boards Check if the silicon revision version check fails for newer or older boards --> hw or sw problem?? Update sw and/or hw #51
Considering we wanna have 2 test equipment, one of this 2 is almost complete but we don't know which components are missing Prepare the BOM for completing the second test equipment so that we can always send one to the tester and keep one in home @MSECode w/ support of others #52

@valegagge
Copy link
Member Author

Thanks @MSECode for updating the table with the relative tasks.

We can close this issue in favor of #53 where we are going to address all these tasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants