Fixed LDO Flow #288
Merged
Fixed LDO Flow #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@harshkhandeparkar any plans to finish this PR? |
Juan was working on fixing the layout/LVS issues. Once they are fixed, this PR might be good to go. |
harshkhandeparkar
force-pushed
the
ldo-fixes
branch
from
cbc06ee to
067afee
Compare
harshkhandeparkar
force-pushed
the
ldo-fixes
branch
2 times, most recently
from
d2d8edf to
533afce
Compare
|
is this ready for review @harshkhandeparkar |
Yes. |
|
If DRC and LVS are passing, you'll need to uncomment the LDO job from the build and test workflow |
chetanyagoyal
requested changes
Aug 19, 2024
openfasoc/generators/ldo-gen/blocks/sky130hvl/gds/vref_gen_nmos_with_trim.gds
Outdated
Show resolved
Hide resolved
openfasoc/generators/ldo-gen/blocks/sky130hvl/lef/vref_gen_nmos_with_trim.lef
Outdated
Show resolved
Hide resolved
harshkhandeparkar
force-pushed
the
ldo-fixes
branch
2 times, most recently
from
e108c4e to
f7af5f4
Compare
chetanyagoyal
approved these changes
Aug 22, 2024
msaligane
approved these changes
Aug 22, 2024
|
@harshkhandeparkar Great! We need to have the CI checks for different configurations. @chetanyagoyal, Can you follow up on this with Harsh? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #264
Changes
LDO_COMPARATOR_LATCHsite to the double-height siteunithvdblprovided by sky130hvl.PT_UNIT_CELLsite tounithvfromunithd, which is meant for sky130hd.VREGvoltage domain size by 1 micron on the x-axis on both sides. This prevents the core area rows from reaching the bottom (See Fig. 1 and Fig. 2)LDO_COMPARATOR_LATCHplacement position, which was wrong because of theMY(mirror along y-axis) orientation.save_images.tclscript. The upstream ORFS changes were incorporated (same as Update save_images.tcl #256).trimpin mismatch issueContext
Figure 1
Floorplan without increasing
VREGdomain size. Rows are colored in green.Figure 2
Floorplan after increasing
VREGdomain size. Rows, colored in green, do not extend to the bottom near the edges.Figure 3
Final output for array size =
129(load current =10mA) and placement density =0.6.Figure 4
Final output for array size =
13(load current =1mA) and placement density =0.35.Figure 5
Allowed (ie, with the placement converging) place densities, estimated placement density according to the current formula, and median allowed densities.