Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One Omnibar Widget #13

Closed
3 tasks
bhubbard opened this issue Nov 9, 2015 · 5 comments
Closed
3 tasks

One Omnibar Widget #13

bhubbard opened this issue Nov 9, 2015 · 5 comments
Labels

Comments

@bhubbard
Copy link
Contributor

bhubbard commented Nov 9, 2015

I think its more confusing to have two omnibar widgets. We should just have just one omnibar widget, with a checkbox option in the widget to display the extra fields.

Even better if we make it a checkbox option for each field we might want to display. Example:

  • Price Max
  • Beds
  • Baths
@csjoblom
Copy link
Contributor

I put in an enhancement request for this consolidation.

sheparddw added a commit that referenced this issue Nov 19, 2015
…ase/1.3.1

* commit '267e14b4005770099467d94e424fd83fbc08a2fa':
  Fix bug where the omnibar does not work properly on strict servers.
@antonioortegajr
Copy link
Contributor

This could be an addition to the exisiting omni bar widget, but getting rid of the omni bar would be a breaking change for users currently using this widget. Backwards compatibility should be considered here.

@bhubbard
Copy link
Contributor Author

I agree backwards compatibility is an issue. That is why I suggest it is done in stages.

Stage 1:
Add all the options (including #31, which was just suggested) to what will become the single omnibar widget. Add a message on the old omnibar widget encouraging users to switch to the new omnibar widget

Stage 2:
Introduce some quick internal reporting/stats to find out how many sites still have the old widget in use, and how many times. Email all site owners/partners who need to update.

Stage 3:
In some future update kill the old widget with a notice, if possible programmatically replace it with the new widget

@bhubbard
Copy link
Contributor Author

bhubbard commented Jan 5, 2016

We have quite a bit of requests for the omnibar widget(s), somewhat related to this request, maybe someone can setup a label for them so we can group the issues. Then they can all be considered and addressed at the same time.

#39, #40, #41, #31, #13

@csjoblom
Copy link
Contributor

@bhubbard I added the omnibar label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants