Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSDM changes for tap water heat demand #1131

Open
5 tasks done
danielfeismann opened this issue Aug 8, 2024 · 0 comments · May be fixed by #1132
Open
5 tasks done

PSDM changes for tap water heat demand #1131

danielfeismann opened this issue Aug 8, 2024 · 0 comments · May be fixed by #1132
Assignees
Labels
model Related to the data model (conceptually, not to the implementation)

Comments

@danielfeismann
Copy link
Member

danielfeismann commented Aug 8, 2024

Based on discussion here there should be created a

  • domestic hot water storage model
  • thermalHouse should be updated by
    • house type
    • number of inhabitants
  • thermal storages should get an attribute pThermalRated
@danielfeismann danielfeismann added the model Related to the data model (conceptually, not to the implementation) label Aug 8, 2024
@danielfeismann danielfeismann self-assigned this Aug 8, 2024
@danielfeismann danielfeismann linked a pull request Aug 8, 2024 that will close this issue
danielfeismann added a commit that referenced this issue Aug 9, 2024
…l' into df/#1131-psdm-update-for-tap-water-demand

# Conflicts:
#	src/main/java/edu/ie3/datamodel/io/factory/input/CylindricalStorageInputFactory.java
#	src/main/java/edu/ie3/datamodel/models/input/thermal/CylindricalStorageInput.java
#	src/main/java/edu/ie3/datamodel/utils/validation/ThermalUnitValidationUtils.java
#	src/test/groovy/edu/ie3/datamodel/utils/validation/ThermalUnitValidationUtilsTest.groovy
danielfeismann added a commit that referenced this issue Aug 14, 2024
…-demand

# Conflicts:
#	src/test/groovy/edu/ie3/datamodel/io/factory/input/CylindricalStorageInputFactoryTest.groovy
danielfeismann added a commit that referenced this issue Aug 26, 2024
…er-demand' into df/#1131-psdm-update-for-tap-water-demand
danielfeismann added a commit that referenced this issue Sep 18, 2024
…er-demand' into df/#1131-psdm-update-for-tap-water-demand
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
model Related to the data model (conceptually, not to the implementation)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant