Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Use last ambientTemperature from lastState #916

Closed
danielfeismann opened this issue Aug 21, 2024 · 1 comment · Fixed by #1053
Closed

Refactor: Use last ambientTemperature from lastState #916

danielfeismann opened this issue Aug 21, 2024 · 1 comment · Fixed by #1053
Assignees
Labels
code quality Code readability or efficiency is improved

Comments

@danielfeismann
Copy link
Member

danielfeismann commented Aug 21, 2024

this should build upon #853

within ThermalGrid.energyDemand I introduced the last ambientTemperature very quick and dirty. This can and should be refactored. The ambientTemperature of the last state is also part of the last HpState and can be taken from there. That would make the method more comprehensive. This may lead to further adaptions...

see:

          Note from my side: In my opinion both temperatures are necessary here, the ambientTemperature of the last state and the actual one. Since the HpState contains the lastAmbientTemperature this can be done nicer and would be a good HiWi-Job. As well some tests for different cases like falling and rising temperature would be great.

Originally posted by @danielfeismann in #853 (comment)

@danielfeismann
Copy link
Member Author

Blocked by #929

Note to self: After #929 is completed update this issue here

@danielfeismann danielfeismann added the blocked externally Progress blocked by outside resource label Sep 19, 2024
@danielfeismann danielfeismann removed the blocked externally Progress blocked by outside resource label Nov 24, 2024
@danielfeismann danielfeismann self-assigned this Nov 24, 2024
sebastian-peter added a commit that referenced this issue Nov 25, 2024
…emperature-from-lastState

Refactoring to only use 'lastHpState' and 'relevantData' for 'Thermal…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Code readability or efficiency is improved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant