You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
within ThermalGrid.energyDemand I introduced the last ambientTemperature very quick and dirty. This can and should be refactored. The ambientTemperature of the last state is also part of the last HpState and can be taken from there. That would make the method more comprehensive. This may lead to further adaptions...
see:
Note from my side: In my opinion both temperatures are necessary here, the ambientTemperature of the last state and the actual one. Since the HpState contains the lastAmbientTemperature this can be done nicer and would be a good HiWi-Job. As well some tests for different cases like falling and rising temperature would be great.
this should build upon #853
within
ThermalGrid.energyDemand
I introduced the last ambientTemperature very quick and dirty. This can and should be refactored. The ambientTemperature of the last state is also part of the last HpState and can be taken from there. That would make the method more comprehensive. This may lead to further adaptions...see:
Originally posted by @danielfeismann in #853 (comment)
The text was updated successfully, but these errors were encountered: