Fix hp results leading to overheating house and other effects

CHANGELOG.md

@@ -115,6 +115,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Improve code quality in fixedloadmodelspec and other tests [#919](https://github.com/ie3-institute/simona/issues/919)
 - Fix power flow calculation with em agents [#962](https://github.com/ie3-institute/simona/issues/962)
 - Fix scheduling at Evcs with more than one Ev at a time without Em [#787](https://github.com/ie3-institute/simona/issues/787)
+- Fixed Hp results leading to overheating house and other effects [#827](https://github.com/ie3-institute/simona/issues/827)
 
 ## [3.0.0] - 2023-08-07
 

src/main/scala/edu/ie3/simona/agent/ValueStore.scala

@@ -22,7 +22,7 @@ import scala.collection.SortedMap
   */
 final case class ValueStore[+D](
     maxTickSpan: Long,
-    private val store: SortedMap[Long, D] = SortedMap.empty[Long, D],
+    store: SortedMap[Long, D] = SortedMap.empty[Long, D],
 ) {
 
   /** Determine the lastly known data tick, if available. Includes the given

src/main/scala/edu/ie3/simona/model/participant/HpModel.scala

@@ -150,6 +150,7 @@ final case class HpModel(
   ): Boolean = {
     val demand = thermalGrid.energyDemand(
       relevantData.currentTick,
+      state.ambientTemperature.getOrElse(relevantData.ambientTemperature),
       relevantData.ambientTemperature,
       state.thermalGridState,
     )
@@ -210,6 +211,7 @@ final case class HpModel(
     /* Determine the options we have */
     val thermalEnergyDemand = thermalGrid.energyDemand(
       data.currentTick,
+      lastState.ambientTemperature.getOrElse(data.ambientTemperature),
       data.ambientTemperature,
       lastState.thermalGridState,
     )