Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hp thermal storage refill #860

Draft
wants to merge 92 commits into
base: dev
Choose a base branch
from

codacy

1f829e6
Select commit
Loading
Failed to load commit list.
Draft

Fix hp thermal storage refill #860

codacy
1f829e6
Select commit
Loading
Failed to load commit list.
SonarQubeGithubPRChecks / simona Sonarqube Results succeeded Aug 21, 2024 in 11s

Quality Gate success

Passed

Analysis Details

4 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 4 Code Smells

Coverage and Duplications

  • Coverage 91.80% Coverage (83.40% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: edu.ie3:simona

View in SonarQube

Annotations

Check notice on line 206 in src/main/scala/edu/ie3/simona/model/thermal/ThermalGrid.scala

See this annotation in the file changed.

@sonarqubegithubprchecks sonarqubegithubprchecks / simona Sonarqube Results

src/main/scala/edu/ie3/simona/model/thermal/ThermalGrid.scala#L206 

Complete the task associated to this TODO comment.

Check warning on line 368 in src/main/scala/edu/ie3/simona/model/thermal/ThermalGrid.scala

See this annotation in the file changed.

@sonarqubegithubprchecks sonarqubegithubprchecks / simona Sonarqube Results

src/main/scala/edu/ie3/simona/model/thermal/ThermalGrid.scala#L368 

Unused parameter

Check warning on line 543 in src/main/scala/edu/ie3/simona/model/thermal/ThermalGrid.scala

See this annotation in the file changed.

@sonarqubegithubprchecks sonarqubegithubprchecks / simona Sonarqube Results

src/main/scala/edu/ie3/simona/model/thermal/ThermalGrid.scala#L543 

Take the required action to fix the issue indicated by this "FIXME" comment.

Check warning on line 315 in src/main/scala/edu/ie3/simona/agent/participant/hp/HpAgentFundamentals.scala

See this annotation in the file changed.

@sonarqubegithubprchecks sonarqubegithubprchecks / simona Sonarqube Results

src/main/scala/edu/ie3/simona/agent/participant/hp/HpAgentFundamentals.scala#L315 

Unnecessary store before return.
View more details on SonarQubeGithubPRChecks