Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-implementation of ParticipantAgent and models #960

Draft
wants to merge 71 commits into
base: dev
Choose a base branch
from

Removing unnecessary imports

044209b
Select commit
Loading
Failed to load commit list.
Refresh
Draft

Re-implementation of ParticipantAgent and models #960

Removing unnecessary imports
044209b
Select commit
Loading
Failed to load commit list.
SonarQubeGithubPRChecks / simona Sonarqube Results succeeded Nov 25, 2024 in 15s

Quality Gate success

Passed

Analysis Details

15 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 15 Code Smells

Coverage and Duplications

  • Coverage 51.10% Coverage (79.20% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: edu.ie3:simona

View in SonarQube

Annotations

Check warning on line 63 in src/test/scala/edu/ie3/simona/model/participant2/PvModelSpec.scala

See this annotation in the file changed.

@sonarqubegithubprchecks sonarqubegithubprchecks / simona Sonarqube Results

src/test/scala/edu/ie3/simona/model/participant2/PvModelSpec.scala#L63 

Null parameter

Check warning on line 68 in src/test/scala/edu/ie3/simona/model/participant2/WecModelSpec.scala

See this annotation in the file changed.

@sonarqubegithubprchecks sonarqubegithubprchecks / simona Sonarqube Results

src/test/scala/edu/ie3/simona/model/participant2/WecModelSpec.scala#L68 

Null parameter

Check warning on line 62 in src/test/scala/edu/ie3/simona/model/participant2/StorageModelSpec.scala

See this annotation in the file changed.

@sonarqubegithubprchecks sonarqubegithubprchecks / simona Sonarqube Results

src/test/scala/edu/ie3/simona/model/participant2/StorageModelSpec.scala#L62 

Null parameter

Check warning on line 74 in src/main/scala/edu/ie3/simona/model/participant2/load/ProfileLoadModel.scala

See this annotation in the file changed.

@sonarqubegithubprchecks sonarqubegithubprchecks / simona Sonarqube Results

src/main/scala/edu/ie3/simona/model/participant2/load/ProfileLoadModel.scala#L74 

Use of asInstanceOf

Check notice on line 87 in src/main/scala/edu/ie3/simona/model/participant2/load/ProfileLoadModel.scala

See this annotation in the file changed.

@sonarqubegithubprchecks sonarqubegithubprchecks / simona Sonarqube Results

src/main/scala/edu/ie3/simona/model/participant2/load/ProfileLoadModel.scala#L87 

Complete the task associated to this TODO comment.

Check notice on line 477 in src/main/scala/edu/ie3/simona/model/participant2/evcs/EvcsModel.scala

See this annotation in the file changed.

@sonarqubegithubprchecks sonarqubegithubprchecks / simona Sonarqube Results

src/main/scala/edu/ie3/simona/model/participant2/evcs/EvcsModel.scala#L477 

Complete the task associated to this TODO comment.

Check failure on line 101 in src/main/scala/edu/ie3/simona/model/participant2/ParticipantModelShell.scala

See this annotation in the file changed.

@sonarqubegithubprchecks sonarqubegithubprchecks / simona Sonarqube Results

src/main/scala/edu/ie3/simona/model/participant2/ParticipantModelShell.scala#L101 

Define a constant instead of duplicating this literal "No relevant data available!" 3 times.

Check warning on line 152 in src/main/scala/edu/ie3/simona/model/participant2/PrimaryDataParticipantModel.scala

See this annotation in the file changed.

@sonarqubegithubprchecks sonarqubegithubprchecks / simona Sonarqube Results

src/main/scala/edu/ie3/simona/model/participant2/PrimaryDataParticipantModel.scala#L152 

Unused parameter

Check warning on line 171 in src/main/scala/edu/ie3/simona/model/participant2/PrimaryDataParticipantModel.scala

See this annotation in the file changed.

@sonarqubegithubprchecks sonarqubegithubprchecks / simona Sonarqube Results

src/main/scala/edu/ie3/simona/model/participant2/PrimaryDataParticipantModel.scala#L171 

Unused parameter

Check notice on line 34 in src/main/scala/edu/ie3/simona/model/participant2/ParticipantFlexibility.scala

See this annotation in the file changed.

@sonarqubegithubprchecks sonarqubegithubprchecks / simona Sonarqube Results

src/main/scala/edu/ie3/simona/model/participant2/ParticipantFlexibility.scala#L34 

Complete the task associated to this TODO comment.

Check warning on line 168 in src/main/scala/edu/ie3/simona/model/participant2/StorageModel.scala

See this annotation in the file changed.

@sonarqubegithubprchecks sonarqubegithubprchecks / simona Sonarqube Results

src/main/scala/edu/ie3/simona/model/participant2/StorageModel.scala#L168 

Take the required action to fix the issue indicated by this "FIXME" comment.

Check notice on line 77 in src/main/scala/edu/ie3/simona/agent/participant2/ParticipantGridAdapter.scala

See this annotation in the file changed.

@sonarqubegithubprchecks sonarqubegithubprchecks / simona Sonarqube Results

src/main/scala/edu/ie3/simona/agent/participant2/ParticipantGridAdapter.scala#L77 

Complete the task associated to this TODO comment.

Check warning on line 160 in src/main/scala/edu/ie3/simona/agent/participant2/ParticipantGridAdapter.scala

See this annotation in the file changed.

@sonarqubegithubprchecks sonarqubegithubprchecks / simona Sonarqube Results

src/main/scala/edu/ie3/simona/agent/participant2/ParticipantGridAdapter.scala#L160 

Remove this commented out code.

Check notice on line 33 in src/main/scala/edu/ie3/simona/agent/participant2/ParticipantAgentInit.scala

See this annotation in the file changed.

@sonarqubegithubprchecks sonarqubegithubprchecks / simona Sonarqube Results

src/main/scala/edu/ie3/simona/agent/participant2/ParticipantAgentInit.scala#L33 

Complete the task associated to this TODO comment.

Check warning on line 83 in src/main/scala/edu/ie3/simona/agent/participant2/ParticipantAgent.scala

See this annotation in the file changed.

@sonarqubegithubprchecks sonarqubegithubprchecks / simona Sonarqube Results

src/main/scala/edu/ie3/simona/agent/participant2/ParticipantAgent.scala#L83 

Unused parameter
View more details on SonarQubeGithubPRChecks