Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmos SDK v0.46.0 upgrade tracking issue #2673

Closed
5 of 8 tasks
aljo242 opened this issue Jul 28, 2022 · 9 comments · Fixed by #2677
Closed
5 of 8 tasks

Cosmos SDK v0.46.0 upgrade tracking issue #2673

aljo242 opened this issue Jul 28, 2022 · 9 comments · Fixed by #2677
Assignees
Milestone

Comments

@aljo242
Copy link
Contributor

aljo242 commented Jul 28, 2022

This issue can track our progress of upgrading ignite to use the Cosmos-SDK v0.46.0.

Checklist

  • feat: Cosmos SDK v0.46.0 tendermint/spn#914
  • Update go.mod to use updated cosmos-sdk, spn, and ibc-go
  • change all imports starting with github.com/cosmos/ibc-go/v3 to github.com/cosmos/ibc-go/v5
  • update app template according to new SDK and test with ignite
  • Test tutorials after all finished - cc @tbruyelle

Post-release checklist

  • Update CHANGELOG
  • Prepare for new release
  • Update documentation, and compatibility table in the readme @fadeev
@aljo242 aljo242 added the Epic label Jul 28, 2022
@aljo242 aljo242 self-assigned this Jul 28, 2022
@aljo242
Copy link
Contributor Author

aljo242 commented Jul 28, 2022

Feel free to add to this

@ilgooz ilgooz added this to the Priority milestone Jul 28, 2022
@ilgooz
Copy link
Member

ilgooz commented Jul 28, 2022

cc @nooomski @marbar3778

@lumtis
Copy link
Contributor

lumtis commented Jul 28, 2022

Feel free to add to this

I don't have anything particular to add. I think

update app template according to new SDK and test with ignite

Can be separated for all scaffolding commands to work on them in parallel, this could be the complex part of the PR

@lumtis
Copy link
Contributor

lumtis commented Jul 28, 2022

May we close #2156 @ilgooz ?

@ilgooz ilgooz linked a pull request Jul 28, 2022 that will close this issue
@ilgooz ilgooz removed a link to a pull request Jul 28, 2022
@ilgooz ilgooz linked a pull request Jul 29, 2022 that will close this issue
@ilgooz
Copy link
Member

ilgooz commented Jul 29, 2022

Hey, I created this PR which is using feat/sdk-ibc-upgrade as the base branch.

I propose to target feat/sdk-ibc-upgrade as the base branch for the future PRs as well and once all of them are merged, we can extensively test that branch before merging it to develop.

This approach could also give us flexibility if we want to make another release from develop while working on this feature in feat/sdk-ibc-upgrade.

@fadeev
Copy link
Contributor

fadeev commented Jul 29, 2022

I can work on the documentation for this.

@ilgooz
Copy link
Member

ilgooz commented Jul 29, 2022

@fadeev That would be great! 🙏

@aljo242
Copy link
Contributor Author

aljo242 commented Jul 29, 2022

Remaining work on #2677 is to modify the templates and proto-gen

@ilgooz
Copy link
Member

ilgooz commented Aug 4, 2022

Since @tbruyelle is vacationing, @jeronimoalbi would you mind taking the part related to running the tutorials and migrating them if there is a need for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants