Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

Separate validation from builders #4

Open
Wopple opened this issue Apr 13, 2015 · 2 comments
Open

Separate validation from builders #4

Wopple opened this issue Apr 13, 2015 · 2 comments

Comments

@Wopple
Copy link
Contributor

Wopple commented Apr 13, 2015

Currently some of the builders perform validation to ensure the data is representative of the specification. The responsibility for validation should be its own component. The builders should only be concerned with building the type.

@derjust
Copy link
Contributor

derjust commented Apr 22, 2015

Just as a bunch of items to consider (as just hit them - might be split up in dedicated issues when they are worked on):

  • Check that TrackData has TrackInfo (Otherwise NullPointerException appears during writing)
    • IMHO already during building the object structure (covers read and in memory construction)
  • Check TARGETDURATION against duration of the TrackData elements
    • IMHO during writing only. Maybe respect lenient vs. strict writing (compare to reading)
  • Check that TrackData has a TrackInfo
    • IMHO already during building the object structure
  • to be continued...

@Wopple Wopple added the medium label Apr 23, 2015
@Wopple
Copy link
Contributor Author

Wopple commented Aug 21, 2015

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants