Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add APIC frame support to 'get' command #2

Open
ikalnytskyi opened this issue Dec 12, 2022 · 3 comments · May be fixed by #16
Open

Add APIC frame support to 'get' command #2

ikalnytskyi opened this issue Dec 12, 2022 · 3 comments · May be fixed by #16

Comments

@ikalnytskyi
Copy link
Owner

APIC frame contains a picture of one of the media file covers. Currently APIC frame support is limited by 'set' command, but not 'get'. We have to figure out the best way to support APIC frame in 'get' command.

At this point two options are considered:

  • Returning a picture from APIC frame inline in base64 form
  • Returning a picture from APIC frame as a temporary file with a reference to it in the metadata text
@ikalnytskyi
Copy link
Owner Author

@malor I wonder what your opinion on this?

@malor
Copy link
Collaborator

malor commented Dec 13, 2022

I want to say a temporary file (some graphical terminal emulators would even recognize a link and make it clickable?), but it's not clear to me who and when is supposed to clean it up later. It's a temporary directory, yes, but multiple calls to get would keep such pics around until the next machine reboot?

@ikalnytskyi
Copy link
Owner Author

I want to say a temporary file (some graphical terminal emulators would even recognize a link and make it clickable?)

Text wrapped into OSC 8 is considered to be a hyperlink by supported terminals. I think this a good idea to provide such functionality.

It's a temporary directory, yes, but multiple calls to get would keep such pics around until the next machine reboot?

Yeah, correct. We can probably implement proper cleanup for 'edit' command by calling 'unlink()' on the file just right after we opened it, but it cannot be applied to 'get' command.

I think we can probably live with that until we implement a better solution. Or maybe considering an extra flag to support base64 format too.

@malor malor linked a pull request Dec 28, 2024 that will close this issue
malor added a commit that referenced this issue Dec 30, 2024
malor added a commit that referenced this issue Dec 31, 2024
malor added a commit that referenced this issue Dec 31, 2024
malor added a commit that referenced this issue Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants