Skip to content

Don't alias subspecs when merge!ing #15

Don't alias subspecs when merge!ing

Don't alias subspecs when merge!ing #15

GitHub Actions / Rspec Tests - 2.7 failed Mar 22, 2024 in 1s

27 passed, 1 failed and 0 skipped

Tests failed

❌ test_results/rspec.xml

28 tests were completed in 152ms with 27 passed, 1 failed and 0 skipped.

Test suite Passed Failed Skipped Time
rspec 27✅ 1❌ 152ms

❌ rspec

spec.unit.deep_preloader_spec
  ✅ DeepPreloader can parse a hash spec
  ❌ DeepPreloader can merge specs
	Failure/Error: association_specs[k].merge!(v)
  ✅ DeepPreloader with a test model can parse a polymorphic hash spec
  ✅ DeepPreloader with a one-to-one relationship in the belongs_to direction is not already loaded
  ✅ DeepPreloader with a one-to-one relationship in the belongs_to direction loads the child
  ✅ DeepPreloader with a one-to-one relationship in the belongs_to direction sets up the inverse relationship
  ✅ DeepPreloader with a one-to-one relationship in the belongs_to direction satisfies a childless parent
  ✅ DeepPreloader with a one-to-one relationship in the belongs_to direction loads more than one entity
  ✅ DeepPreloader with a one-to-one relationship in the belongs_to direction uses preloaded children from other parents before hitting the database
  ✅ DeepPreloader with a one-to-one relationship in the belongs_to direction supports locking
  ✅ DeepPreloader with a one-to-one relationship in the has_one direction loads the parent
  ✅ DeepPreloader with a one-to-one relationship in the has_one direction sets up the inverse relationship
  ✅ DeepPreloader with a one-to-one relationship in the has_one direction satisfies a parentless child
  ✅ DeepPreloader with a one-to-one relationship in the has_one direction loads more than one entity
  ✅ DeepPreloader with a one-to-one relationship in the has_one direction handles a preloaded child
  ✅ DeepPreloader with multiple belongs_to relationships with distinct children loads multiple relationships at once
  ✅ DeepPreloader with multiple belongs_to relationships with a diamond loads the same child for all three
  ✅ DeepPreloader with a has_many relationship loads the child
  ✅ DeepPreloader with a has_many relationship sets up the inverse relationship
  ✅ DeepPreloader with a has_many relationship satisfies a childless parent
  ✅ DeepPreloader with a has_many relationship handles preloaded children
  ✅ DeepPreloader with a has_many STI relationship loads the children
  ✅ DeepPreloader with a has_many STI relationship loads polymorphically through the children
  ✅ DeepPreloader with a polymorphic relationship loads different child types
  ✅ DeepPreloader with a polymorphic relationship sets the inverse associations
  ✅ DeepPreloader with a polymorphic relationship separates parent context when loading backwards
  ✅ DeepPreloader with a polymorphic relationship satisfies a childless parent
  ✅ DeepPreloader with a polymorphic relationship with grandchildren loads sub-specs through the polymorphic association

Annotations

Check failure on line 0 in test_results/rspec.xml

See this annotation in the file changed.

@github-actions github-actions / Rspec Tests - 2.7

rspec ► spec.unit.deep_preloader_spec ► DeepPreloader can merge specs

Failed test found in:
  test_results/rspec.xml
Error:
  Failure/Error: association_specs[k].merge!(v)
Raw output
Failure/Error: association_specs[k].merge!(v)

NoMethodError:
  undefined method `merge!' for :b:Symbol
./lib/deep_preloader/spec.rb:39:in `block in merge!'
./lib/deep_preloader/spec.rb:37:in `each'
./lib/deep_preloader/spec.rb:37:in `merge!'
./spec/unit/deep_preloader_spec.rb:40:in `block (2 levels) in <top (required)>'
./spec/spec_helper.rb:118:in `block (3 levels) in <top (required)>'
./vendor/bundle/ruby/2.7.0/gems/database_cleaner-core-2.0.1/lib/database_cleaner/strategy.rb:30:in `cleaning'
./vendor/bundle/ruby/2.7.0/gems/database_cleaner-core-2.0.1/lib/database_cleaner/cleaners.rb:34:in `block (2 levels) in cleaning'
./vendor/bundle/ruby/2.7.0/gems/database_cleaner-core-2.0.1/lib/database_cleaner/cleaners.rb:35:in `cleaning'
./spec/spec_helper.rb:117:in `block (2 levels) in <top (required)>'