Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ViewModel::ActiveRecord::Controller#destroy now returns 204 No Content. #66

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

OxleyS
Copy link
Contributor

@OxleyS OxleyS commented Apr 27, 2017

No description provided.

@OxleyS
Copy link
Contributor Author

OxleyS commented Apr 27, 2017

I had only changed ViewModel::ActiveRecord::Controller#destroy, but it seems there is also ViewModel::ActiveRecord::SingularNestedController and ViewModel::ActiveRecord::CollectionNestedController. All actions related to destroying return a 'data': null response, except for ViewModel::ActiveRecord::CollectionNestedController#disassociate_all, which returns a 'data': [] response instead. What is the rationale for this?

@chrisandreae
Copy link
Member

The routes you mention are for manipulating an association, and returned the new value of the association: null in the case of a single association and empty list in case of multiple.

@chrisandreae
Copy link
Member

What do we want to do about this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants