Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isMeters variable name(s) #4

Open
RaananW opened this issue Nov 25, 2020 · 2 comments
Open

isMeters variable name(s) #4

RaananW opened this issue Nov 25, 2020 · 2 comments

Comments

@RaananW
Copy link
Contributor

RaananW commented Nov 25, 2020

There are two parameters in the proposed IDL that have inMeters in their name: measuredWidthInMeters and widthInMeters.

As XR units are already in meters, and other APIs don't have this name definitions, is that needed in this API?

@klausw
Copy link
Contributor

klausw commented Nov 25, 2020

I'm open to suggestions, but I think that an attribute named width that's provided alongside a bitmap image is too easy to misinterpret as a pixel width. It's not immediately clear from context that this is intended to be a real-world dimension.

@RaananW
Copy link
Contributor Author

RaananW commented Nov 26, 2020

Yep, you are right. Apart from realWorldWidth or worldWidth that corresponds with worldInformation from plane detection (which is also not ideal) I don't have any better suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants