Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: support compiling with -fvisibility=hidden #442

Closed
Tracked by #435
kkysen opened this issue Oct 13, 2024 · 0 comments · Fixed by #444
Closed
Tracked by #435

runtime: support compiling with -fvisibility=hidden #442

kkysen opened this issue Oct 13, 2024 · 0 comments · Fixed by #444
Assignees

Comments

@kkysen
Copy link
Contributor

kkysen commented Oct 13, 2024

For the runtime support for -fvisibility=hidden, we just need to mark the runtime functions that are called across translation units as having default (i.e. exported) visibility with __attribute__((visibility("default"))).

@kkysen kkysen self-assigned this Oct 13, 2024
kkysen added a commit that referenced this issue Oct 13, 2024
…visibility("default")))`

* Fixes #442.

Making the visibility explicit for these allows projects to be compiled with `-fvisibility=hidden`,
which sets the default (not `default`) to `hidden`.
kkysen added a commit that referenced this issue Oct 13, 2024
…visibility("default")))`

* Fixes #442.

Making the visibility explicit for these allows projects to be compiled with `-fvisibility=hidden`,
which sets the default (not `default`) to `hidden`.
kkysen added a commit that referenced this issue Oct 14, 2024
…visibility("default")))`

* Fixes #442.

Making the visibility explicit for these allows projects to be compiled with `-fvisibility=hidden`,
which sets the default (not `default`) to `hidden`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant