Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an internal IR for DWARF info #6

Open
ayrtonm opened this issue Apr 13, 2022 · 0 comments
Open

Create an internal IR for DWARF info #6

ayrtonm opened this issue Apr 13, 2022 · 0 comments

Comments

@ayrtonm
Copy link
Contributor

ayrtonm commented Apr 13, 2022

The EntryRef methods in dwarf_entry.rs duplicate some code since the various input sources provide different DWARF function and variable entry attributes. We could deduplicate quite a bit by creating an internal IR for DWARF function and variable entries.

Essentially these structs would have Option<T> fields for the entry attributes. We may possibly want to use a different enum with three variants to distinguish between input sources that cannot provide a certain attribute and those that can, but did not provide it. Then the parsed input data would be transformed into this IR (instead of the current AnvillData, GhidraData, etc...) and we could use a single function to update the DWARF function entries and another for variables. This wouldn't change the behavior of this tool, but would be good to have before adding any more input sources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant