[TP-2147] Add Gem Game contract #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pano-skylakis
commented
Apr 11, 2024
Comment on lines
+15
to
+25
| interface IDeployer { | ||
| function deploy(bytes memory bytecode, bytes32 salt) external payable returns (address deployedAddress_); | ||
| function deployAndInit(bytes memory bytecode, bytes32 salt, bytes calldata init) | ||
| external | ||
| payable | ||
| returns (address deployedAddress_); | ||
| function deployedAddress(bytes calldata bytecode, address sender, bytes32 salt) | ||
| external | ||
| view | ||
| returns (address deployedAddress_); | ||
| } |
There was a problem hiding this comment.
@drinkcoffee thoughts on moving this somewhere where it can be reused? Something else we could do is install the contract-deployer repository and potentially import from there 🤔
jeetparikh
previously approved these changes
Apr 12, 2024
…m/immutable/contracts into ps/tp-2147/add-gems-game-contract
feenaIMX
approved these changes
Apr 12, 2024
keithbro-imx
approved these changes
Apr 12, 2024
pano-skylakis
commented
Apr 12, 2024
Comment on lines
+7
to
+18
| | Environment/Network | Deployment Address | Commit Hash | | ||
| |--------------------------|--------------------|-------------| | ||
| | imtbl-zkevm-testnet | - | - | | ||
| | imtbl-zkevm-mainnet | - | - | | ||
|
|
||
| # Status | ||
|
|
||
| Contract threat models and audits: | ||
|
|
||
| | Description | Date |Version Audited | Link to Report | | ||
| |---------------------------|------------------|-----------------|----------------| | ||
| | Not audited and no threat model | - | - | - | |
There was a problem hiding this comment.
Will populate these in a follow-up PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new contract -
GemGame.This contract includes a single function which emits an event. This event is intended to be indexed off-chain.