Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate presentation IDs used for linked VPs #147

Open
maiertech opened this issue Nov 21, 2024 · 1 comment
Open

Validate presentation IDs used for linked VPs #147

maiertech opened this issue Nov 21, 2024 · 1 comment
Labels
Added A new feature that requires a minor release.

Comments

@maiertech
Copy link
Member

Description

Currently, UniCore does not check if the presentation IDs submitted with /v0/services/linked-vp exist. While refactoring the company wallet, I accidentally submitted [''] instead of [] and UniCore was happy with it.

UniCore should not trust a client to submit valid presentation IDs and instead validate them and return status 400 if any presentation ID does not exist. Then a client can trust UniCore that it returns valid presentation IDs with /v0/services/linked-verifiable-presentation-service.

Motivation

Make API more robust.

Resources

No response

To-do List

n/a
@maiertech maiertech added the Added A new feature that requires a minor release. label Nov 21, 2024
@M-Adam-Hus
Copy link

Validate presentation IDs used for linked VPs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Added A new feature that requires a minor release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maiertech @M-Adam-Hus